From: Christoph Hellwig <hch@lst.de>
To: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/4] pnfs/blocklayout: allocate separate pages for the layoutcommit payload
Date: Thu, 11 Sep 2014 17:27:43 +0200 [thread overview]
Message-ID: <20140911152743.GE6690@lst.de> (raw)
In-Reply-To: <5411AED8.4020204@Netapp.com>
On Thu, Sep 11, 2014 at 10:16:56AM -0400, Anna Schumaker wrote:
> > + arg->layoutupdate_pages =
> > + kcalloc(DIV_ROUND_UP(buffer_size, PAGE_SIZE),
> > + sizeof(struct page *), GFP_NOFS);
>
> I don't think I've seen kcalloc() before. What does it do?
The same as calloc(3) in userspace - allocate an array of nent entries
of size, and zero the result that is returned.
> > dprintk("%s found %i ranges\n", __func__, count);
>
> I'm getting this:
>
> fs/nfs/blocklayout/extent_tree.c: In function ‘ext_tree_prepare_commit’:
> fs/nfs/blocklayout/extent_tree.c:565:2: warning: format ‘%i’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat=]
> dprintk("%s found %i ranges\n", __func__, count);
For some reason I haven't managed to trigger this warning even after
turning on CONFIG_SUNRPC_DEBUG, but it should be easy to fix up..
next prev parent reply other threads:[~2014-09-11 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 0:36 a few more pnfs/blocklayout fixes Christoph Hellwig
2014-09-11 0:36 ` [PATCH 1/4] pnfs/blocklayout: remove some debugging Christoph Hellwig
2014-09-11 0:36 ` [PATCH 2/4] pnfs/objlayout: fix endianess annotation in objio_alloc_deviceid_node Christoph Hellwig
2014-09-11 0:36 ` [PATCH 3/4] pnfs/blocklayout: allocate separate pages for the layoutcommit payload Christoph Hellwig
2014-09-11 14:16 ` Anna Schumaker
2014-09-11 15:27 ` Christoph Hellwig [this message]
2014-09-11 15:59 ` Anna Schumaker
2014-09-11 16:00 ` Anna Schumaker
2014-09-11 0:36 ` [PATCH 4/4] pnfs: remove GETDEVICELIST implementation Christoph Hellwig
2014-09-11 14:51 ` Peng Tao
2014-09-11 15:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911152743.GE6690@lst.de \
--to=hch@lst.de \
--cc=Anna.Schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).