From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@primarydata.com>
Cc: steved@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v3 2/7] nfsdcltrack: update comments in sqlite.c
Date: Thu, 11 Sep 2014 11:53:24 -0400 [thread overview]
Message-ID: <20140911155324.GB16635@fieldses.org> (raw)
In-Reply-To: <1410193821-25109-3-git-send-email-jlayton@primarydata.com>
On Mon, Sep 08, 2014 at 12:30:16PM -0400, Jeff Layton wrote:
> Clean up and fix some inaccuracies.
By the way, I also notice the man page refers to it as a daemon.
--b.
>
> Signed-off-by: Jeff Layton <jlayton@primarydata.com>
> ---
> utils/nfsdcltrack/sqlite.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/utils/nfsdcltrack/sqlite.c b/utils/nfsdcltrack/sqlite.c
> index bac678980938..352f029d55c0 100644
> --- a/utils/nfsdcltrack/sqlite.c
> +++ b/utils/nfsdcltrack/sqlite.c
> @@ -21,17 +21,15 @@
> * Explanation:
> *
> * This file contains the code to manage the sqlite backend database for the
> - * clstated upcall daemon.
> + * nfsdcltrack usermodehelper upcall program.
> *
> * The main database is called main.sqlite and contains the following tables:
> *
> * parameters: simple key/value pairs for storing database info
> *
> - * clients: one column containing a BLOB with the as sent by the client
> - * and a timestamp (in epoch seconds) of when the record was
> - * established
> - *
> - * FIXME: should we also record the fsid being accessed?
> + * clients: an "id" column containing a BLOB with the long-form clientid as
> + * sent by the client, a "time" column containing a timestamp (in
> + * epoch seconds) of when the record was last updated.
> */
>
> #ifdef HAVE_CONFIG_H
> --
> 1.9.3
>
next prev parent reply other threads:[~2014-09-11 15:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 16:30 [PATCH v3 0/7] nfs-utils: support for lifting grace period early Jeff Layton
2014-09-08 16:30 ` [PATCH v3 1/7] sm-notify: inform the kernel if there were no hosts to notify Jeff Layton
2014-09-08 16:30 ` [PATCH v3 2/7] nfsdcltrack: update comments in sqlite.c Jeff Layton
2014-09-11 15:53 ` J. Bruce Fields [this message]
2014-09-08 16:30 ` [PATCH v3 3/7] nfsdcltrack: rename CLD_* constants with CLTRACK_* prefixes Jeff Layton
2014-09-08 16:30 ` [PATCH v3 4/7] nfsdcltrack: overhaul database initializtion Jeff Layton
2014-09-08 16:30 ` [PATCH v3 5/7] nfsdcltrack: update schema to v2 Jeff Layton
2014-09-11 19:55 ` J. Bruce Fields
2014-09-11 20:28 ` Jeff Layton
2014-09-12 13:36 ` Jeff Layton
2014-09-12 14:21 ` Jeff Layton
2014-09-12 14:36 ` J. Bruce Fields
2014-09-12 15:21 ` J. Bruce Fields
2014-09-12 15:54 ` Trond Myklebust
2014-09-12 16:05 ` J. Bruce Fields
2014-09-12 16:07 ` Jeff Layton
2014-09-12 16:29 ` Trond Myklebust
2014-09-12 16:33 ` Jeff Layton
2014-09-12 15:42 ` Trond Myklebust
2014-09-08 16:30 ` [PATCH v3 6/7] nfsdcltrack: grab the NFSDCLTRACK_RECLAIM_COMPLETE env var if it's present Jeff Layton
2014-09-08 16:30 ` [PATCH v3 7/7] nfsdcltrack: fetch NFSDCLTRACK_GRACE_START out of environment Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911155324.GB16635@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).