From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Christoph Hellwig <hch@infradead.org>, linux-nfs@vger.kernel.org
Subject: Re: NFSv2/3 vs v4 error codes?
Date: Thu, 11 Sep 2014 13:02:14 -0700 [thread overview]
Message-ID: <20140911200214.GA21392@infradead.org> (raw)
In-Reply-To: <20140911190345.GA20501@fieldses.org>
On Thu, Sep 11, 2014 at 03:03:45PM -0400, J. Bruce Fields wrote:
> On Wed, Sep 10, 2014 at 03:16:50PM -0700, Christoph Hellwig wrote:
> > As a followup to the fallocate discussion I checked what we map ENODEV
> > to in nfsd. Turns out we map it to NFSERR_NODEV, which doesn't exist
> > in eiter NFSv4.0 nor NFSv4.1 despite the comment in
> > include/uapi/linux/nfs.h claiming otherwise.
>
> That's interesting. Is there a reasonable alternative, or is this a
> protocol bug?
I still haven't figured this out. RFC1813 mentions NFS3ERR_NODEV, but
doesn't actually reference it anywhere.
In general it seems to me like the use of ENODEV in fallocate is the
bug, as we don't really return it from any other filesystem operation.
> > I also just ran into another issue where nfserrno translates a large
> > lits of errors into NFSERR_JUKEBOX, but for v4 we'd really want
> > NFSERR_DELAY instead for most of them.
>
> The distinction is academic as they're both 10008.
Oh, right. I missed to spot that.
> > Is it time for a version specific errno mapping?
>
> I'm certainly not opposed if it turns out to be necessary.
A start might be to move nfserrno out of the NFSv2-specific nfsproc
file..
next prev parent reply other threads:[~2014-09-11 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 22:16 NFSv2/3 vs v4 error codes? Christoph Hellwig
2014-09-11 19:03 ` J. Bruce Fields
2014-09-11 20:02 ` Christoph Hellwig [this message]
2014-09-12 17:55 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911200214.GA21392@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).