From: Christoph Hellwig <hch@lst.de>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: Christoph Hellwig <hch@lst.de>,
Benny Halevy <bhalevy@primarydata.com>,
linux-nfs@vger.kernel.org
Subject: Re: layoutcommit space reservation for the objlayout driver
Date: Mon, 15 Sep 2014 19:12:12 +0200 [thread overview]
Message-ID: <20140915171212.GA23765@lst.de> (raw)
In-Reply-To: <5416ABF3.3040403@plexistor.com>
On Mon, Sep 15, 2014 at 12:05:55PM +0300, Boaz Harrosh wrote:
> I do not understand. This used to work just fine. Please point me to
> the patch that broke it?
> (And since when are we allowed to brake old code?)
I bet it still works the same way it does as commited, which doesn't
make it right. The way the NFS XDR buffer allocations work seems to be
that you can actually slightly overun it without things falling apart,
but that doesn't make it right. E.g. it took a fairly larger overrun
in the block layout driver to finally find the issues, and most of the
time it was just silent truncations, real corruption happened less
often.
But to make sure things work properly in the long run you'd really want
to have the proper allocation.
next prev parent reply other threads:[~2014-09-15 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 16:46 layoutcommit space reservation for the objlayout driver Christoph Hellwig
2014-09-15 9:05 ` Boaz Harrosh
2014-09-15 17:12 ` Christoph Hellwig [this message]
2014-09-16 8:32 ` Boaz Harrosh
[not found] <1538636805.101.1410805338811.JavaMail.root@thunderbeast.private.linuxbox.com>
2014-09-15 18:22 ` Daniel Gryniewicz
2014-09-15 21:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915171212.GA23765@lst.de \
--to=hch@lst.de \
--cc=bhalevy@primarydata.com \
--cc=boaz@plexistor.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).