From: NeilBrown <neilb@suse.de>
To: Trond Myklebust <trond.myklebust@primarydata.com>,
Jeff Layton <jeff.layton@primarydata.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/4] Remove possible deadlocks in nfs_release_page() - V2
Date: Thu, 18 Sep 2014 16:03:17 +1000 [thread overview]
Message-ID: <20140918055907.23854.32118.stgit@notabene.brown> (raw)
These two patches are updated versions of the last two patches of this
series. They include the use of congestion to avoid excessive
waiting.
(I'm not resenting 1/4 and 2/4, they are unchanged).
Without the congestion check, I've seen wait times in
try_to_free_pages as long as 208 seconds.
With no waiting at all in nfs_release_page() I've seen wait times as long
as 1.4 seconds.
With the 1 second wait, I've seen 2 seconds.
These numbers will vary based on numerous factors, but it does seem
to suggest that 1 second is a good ball-park number.
NeilBrown
---
NeilBrown (2):
NFS: avoid deadlocks with loop-back mounted NFS filesystems.
NFS/SUNRPC: Remove other deadlock-avoidance mechanisms in nfs_release_page()
fs/nfs/file.c | 28 ++++++++++++++++++----------
fs/nfs/write.c | 7 +++++++
net/sunrpc/sched.c | 2 --
net/sunrpc/xprtrdma/transport.c | 2 --
net/sunrpc/xprtsock.c | 10 ----------
5 files changed, 25 insertions(+), 24 deletions(-)
--
Signature
next reply other threads:[~2014-09-18 6:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 6:03 NeilBrown [this message]
2014-09-18 6:03 ` [PATCH 3/4] NFS: avoid deadlocks with loop-back mounted NFS filesystems NeilBrown
2014-09-18 12:01 ` Jeff Layton
2014-09-22 1:37 ` NeilBrown
2014-09-18 6:03 ` [PATCH 4/4] NFS/SUNRPC: Remove other deadlock-avoidance mechanisms in nfs_release_page() NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918055907.23854.32118.stgit@notabene.brown \
--to=neilb@suse.de \
--cc=jeff.layton@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).