Re: [PATCH 3/4] nfsd: split nfsd4_callback initialization and use

Christoph Hellwig
2014-09-24T16:43:44Z

On Wed, Sep 24, 2014 at 11:29:54AM -0400, Jeff Layton wrote:
> > Split out initializing the nfs4_callback structure from using it. For
> > the NULL callback this gets rid of tons of pointless re-initializations.
> >
> > Note that I don't quite understand what protects us from running multiple
> > NULL callbacks at the same time, but at least this chance doesn't make
> > it worse..
> >
>
> Doesn't the workqueue ensure that? Or am I misunderstanding what you're
> saying there?

For the code after my patch that is indeed the case, but before my
patch we'd re-initialize various fields in cl_cb_null everytime
do_probe_callback gets called.