From: Christoph Hellwig <hch@infradead.org>
To: Thomas Haynes <thomas.haynes@primarydata.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
Linux NFS Mailing list <linux-nfs@vger.kernel.org>,
Tom Haynes <loghyr@primarydata.com>
Subject: Re: [PATCH] pnfs: Do not schedule layout segment work if there is no work to be done.
Date: Tue, 7 Oct 2014 11:02:50 -0700 [thread overview]
Message-ID: <20141007180250.GA623@infradead.org> (raw)
In-Reply-To: <1412704787-46388-1-git-send-email-Thomas.Haynes@primarydata.com>
On Tue, Oct 07, 2014 at 10:59:47AM -0700, Thomas Haynes wrote:
> From: Tom Haynes <loghyr@primarydata.com>
>
> Callers of pnfs_put_lseg_async() might encounter no writes to
> be committed, etc. As such, do not attempt to add work if none
> is needed. Also, don't oops if that is the case.
I think that last issue is the main culprit, isn't it? :)
I still think adding the NULL check to filelayout_clear_request_commit
would be more reasonable, as it's clear that freeme can be NULL there,
but as pnfs_put_lseg accepts a NULL lseg it's probably wise to keep
the two in sync.
prev parent reply other threads:[~2014-10-07 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 17:59 [PATCH] pnfs: Do not schedule layout segment work if there is no work to be done Thomas Haynes
2014-10-07 18:02 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007180250.GA623@infradead.org \
--to=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=loghyr@primarydata.com \
--cc=thomas.haynes@primarydata.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox