From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jeff.layton@primarydata.com>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: convert nfs4_file searches to use RCU
Date: Tue, 21 Oct 2014 04:52:58 -0700 [thread overview]
Message-ID: <20141021115258.GA14331@infradead.org> (raw)
In-Reply-To: <20141021071606.17f2513f@tlielax.poochiereds.net>
On Tue, Oct 21, 2014 at 07:16:06AM -0400, Jeff Layton wrote:
> Yeah, that's probably fine. Suggestions on what to union it with?
>
> struct callback_head is two pointers, so maybe we can use one of the
> list_heads (fi_delegations maybe?).
Sounds reasonable to me.
> If we do want to change to a different type of structure I'd be fine
> with that, but would prefer that it be RCU-friendly. What sort of
> structure did you have in mind?
For the XFS inode lookup we use multiple radix trees, which work
very well for how inode numbers work in XFS with a clear allocation
group component, and usual clustering of inode numbers. A simple
radix tree might work fine for NFSd, or maybe the new resizable hash
tables from the networking folks?
next prev parent reply other threads:[~2014-10-21 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 10:21 [PATCH] nfsd: convert nfs4_file searches to use RCU Jeff Layton
2014-10-21 10:40 ` Christoph Hellwig
2014-10-21 11:16 ` Jeff Layton
2014-10-21 11:52 ` Christoph Hellwig [this message]
2014-10-23 12:01 ` [PATCH v2] " Jeff Layton
2014-10-28 8:35 ` Christoph Hellwig
2014-11-07 21:54 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021115258.GA14331@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=jeff.layton@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox