From: Christoph Hellwig <hch@infradead.org>
To: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: Trond.Myklebust@primarydata.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v3] NFS: Implement SEEK
Date: Thu, 23 Oct 2014 00:36:08 -0700 [thread overview]
Message-ID: <20141023073608.GB18399@infradead.org> (raw)
In-Reply-To: <54480A77.4000804@Netapp.com>
On Wed, Oct 22, 2014 at 03:50:15PM -0400, Anna Schumaker wrote:
> > int nfs4_call_sync(struct rpc_clnt *clnt,
> > struct nfs_server *server,
> > struct rpc_message *msg,
> > @@ -8431,7 +8430,8 @@ static const struct nfs4_minor_version_ops nfs_v4_2_minor_ops = {
> > | NFS_CAP_CHANGE_ATTR
> > | NFS_CAP_POSIX_LOCK
> > | NFS_CAP_STATEID_NFSV41
> > - | NFS_CAP_ATOMIC_OPEN_V1,
> > + | NFS_CAP_ATOMIC_OPEN_V1
> > + | NFS_CAP_SEEK,
>
> This looks like it really does add the capability to nfs_v4_2_minor_ops, so I'm not sure how it ended up modifying nfs_v4_1_minor_ops instead. Anyway, I just posted a fix to set the flag in the right place.
Given that the caps were the same before this is something that patch
can easily do when applying patches with a fuzz.
prev parent reply other threads:[~2014-10-23 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 17:58 [PATCH v3] NFS: Add v4.2 SEEK support Anna Schumaker
2014-09-26 17:58 ` [PATCH v3] NFS: Implement SEEK Anna Schumaker
2014-10-22 19:50 ` Anna Schumaker
2014-10-23 7:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023073608.GB18399@infradead.org \
--to=hch@infradead.org \
--cc=Anna.Schumaker@netapp.com \
--cc=Trond.Myklebust@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox