From: "J. Bruce Fields" <bfields@fieldses.org>
To: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: Trond.Myklebust@primarydata.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] NFS: SEEK is an NFS v4.2 feature
Date: Thu, 23 Oct 2014 13:34:35 -0400 [thread overview]
Message-ID: <20141023173435.GC16717@fieldses.org> (raw)
In-Reply-To: <1414007590-14286-1-git-send-email-Anna.Schumaker@Netapp.com>
On Wed, Oct 22, 2014 at 03:53:10PM -0400, Anna Schumaker wrote:
> Somehow the nfs_v4_1_minor_ops had the NFS_CAP_SEEK flag set, enabling
> SEEK over v4.1. This is wrong, and can make servers crash.
>
> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Thanks!
Tested-by: J. Bruce Fields <bfields@redhat.com>
--b.
> ---
> v2: Fix compile error
>
> fs/nfs/nfs4proc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 405bd95..8aba549 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -8408,8 +8408,7 @@ static const struct nfs4_minor_version_ops nfs_v4_1_minor_ops = {
> | NFS_CAP_CHANGE_ATTR
> | NFS_CAP_POSIX_LOCK
> | NFS_CAP_STATEID_NFSV41
> - | NFS_CAP_ATOMIC_OPEN_V1
> - | NFS_CAP_SEEK,
> + | NFS_CAP_ATOMIC_OPEN_V1,
> .init_client = nfs41_init_client,
> .shutdown_client = nfs41_shutdown_client,
> .match_stateid = nfs41_match_stateid,
> @@ -8431,7 +8430,8 @@ static const struct nfs4_minor_version_ops nfs_v4_2_minor_ops = {
> | NFS_CAP_CHANGE_ATTR
> | NFS_CAP_POSIX_LOCK
> | NFS_CAP_STATEID_NFSV41
> - | NFS_CAP_ATOMIC_OPEN_V1,
> + | NFS_CAP_ATOMIC_OPEN_V1
> + | NFS_CAP_SEEK,
> .init_client = nfs41_init_client,
> .shutdown_client = nfs41_shutdown_client,
> .match_stateid = nfs41_match_stateid,
> --
> 2.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-10-23 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 19:53 [PATCH v2] NFS: SEEK is an NFS v4.2 feature Anna Schumaker
2014-10-23 17:34 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023173435.GC16717@fieldses.org \
--to=bfields@fieldses.org \
--cc=Anna.Schumaker@netapp.com \
--cc=Trond.Myklebust@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox