public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: nfs atime semantics, was: Re: [PATCH 3/4] common: skip atime related tests on NFS
Date: Thu, 30 Oct 2014 02:03:06 -0700	[thread overview]
Message-ID: <20141030090306.GA23917@infradead.org> (raw)
In-Reply-To: <1414502171-10319-4-git-send-email-eguan@redhat.com>

On Tue, Oct 28, 2014 at 09:16:10PM +0800, Eryu Guan wrote:
> >From nfs(5) we can know that atime related mount options have no effect
> on NFS mounts, so add _require_atime() helper to skip atime tests on NFS

I' like to use this opportunity to start a discussion on NFS atime
handlign again, which I think is broken.  I think relatime is perfectly
fine default semantics for NFS, and not supporting it can cause all
kidns of application breakage.  Supporting normal atime semantics when
explicity requested is also something NFS shouldn't sneak out of.

> Also change the way how _require_relatime() mount $SCRATCH_DEV, use
> _scratch_mount helper so it's mounted with selinux context, to avoid
> "same superblock, different selinux context" failure.

Can you please split this part into a separate patch?


  reply	other threads:[~2014-10-30  9:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 13:16 [RFC PATCH 0/4] re-enable tests that require scratch dev on NFS Eryu Guan
2014-10-28 13:16 ` [PATCH 1/4] common: " Eryu Guan
2014-10-28 13:22   ` Christoph Hellwig
2014-10-29  6:59     ` Eryu Guan
2014-10-28 13:16 ` [PATCH 2/4] common: add _require_block_device() helper Eryu Guan
2014-10-28 13:24   ` Christoph Hellwig
2014-10-28 13:16 ` [PATCH 3/4] common: skip atime related tests on NFS Eryu Guan
2014-10-30  9:03   ` Christoph Hellwig [this message]
2014-10-31  8:13     ` nfs atime semantics, was: " Eryu Guan
2014-10-31 11:31     ` Trond Myklebust
2014-11-02 18:02       ` Boaz Harrosh
2014-11-05  8:29       ` Christoph Hellwig
2014-10-28 13:16 ` [PATCH 4/4] generic/277: add _require_attrs Eryu Guan
2014-10-28 13:23   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141030090306.GA23917@infradead.org \
    --to=hch@infradead.org \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox