Re: [PATCH 1/4] common: re-enable tests that require scratch dev on NFS

Eryu Guan
2014-10-29T07:00:03Z

On Tue, Oct 28, 2014 at 06:22:52AM -0700, Christoph Hellwig wrote:
> On Tue, Oct 28, 2014 at 09:16:08PM +0800, Eryu Guan wrote:
> > index 747cf72..8738da7 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -558,7 +558,11 @@ _scratch_mkfs()
> > _scratch_mkfs_xfs $*
> > ;;
> > nfs*)
> > - # do nothing for nfs
> > + # unable to re-create NFS, just remove all files in $SCRATCH_MNT to
> > + # avoid EEXIST caused by the leftover files created in previous runs
> > + _scratch_mount
> > + rm -rf $SCRATCH_MNT/*
> > + _scratch_unmount
>
> Please move this into a helper, and wire it up for cifs as well.
>

Will do in v2.

Thanks for the review!

Eryu