From: NeilBrown <neilb@suse.de>
To: Steve Dickson <SteveD@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] rpc.svcgssd: Add a configure switch to disable building the daemon
Date: Thu, 6 Nov 2014 06:45:14 +1100 [thread overview]
Message-ID: <20141106064514.4b8fd215@notabene.brown> (raw)
In-Reply-To: <545A4D8E.5010106@RedHat.com>
[-- Attachment #1: Type: text/plain, Size: 2067 bytes --]
On Wed, 05 Nov 2014 11:17:18 -0500 Steve Dickson <SteveD@redhat.com> wrote:
>
>
> On 11/04/2014 09:56 PM, NeilBrown wrote:
> > Hi Steve,
> > I just noticed that this causes an error when I try "./configure".
> > It tries to run a program called "enable_svcgss" with args "=" and "yes",
> > but this fails....
> >
> > A simple fix would leave the code doing nothing if enable_gss = yes, but
> > enable_svcgss = no. Is that what you want?
> No...
>
> >
> > Should it be:
> >
> > if test "$enable_gss" = yes -a "$enable_svcgss" = yes; then
> > SVCGSSD=svcgssd
> >> > + else
> >> > + enable_svcgss=
> >> > + SVCGSSD=
> >> > + fi
> > ??
> >
> > Would you like a patch, or will you just fix it up?
> I got it... thanks!
>
> commit e186d734cb3d7c53ef8038b2f62e5b1825d9fa26
> Author: Steve Dickson <steved@redhat.com>
> Date: Wed Nov 5 11:12:03 2014 -0500
>
> configure: Fixed logic around $enable_gss and $enable_svcgss
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
>
> diff --git a/configure.ac b/configure.ac
> index 59fd14d..377ba2e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -108,10 +108,8 @@ AC_ARG_ENABLE(svcgss,
> [enable building svcgssd for rpcsec_gss server support @<:@default=yes@:>@])],
> enable_svcgss=$enableval,
> enable_svcgss=yes)
> - if test "$enable_gss" = yes; then
> - if "enable_svcgss" = yes; then
> - SVCGSSD=svcgssd
> - fi
> + if test "$enable_gss" = yes -a "enable_svcgss" = yes; then
$
> + SVCGSSD=svcgssd
> else
> enable_svcgss=
> SVCGSSD=
Apart from the missing '$', looks good to me - thanks.
NeilBrown
>
>
> steved.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2014-11-05 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 16:21 [PATCH 0/2] Use the gssproxy damon for GSSAPI credentials (v4) Steve Dickson
2014-09-23 16:21 ` [PATCH 1/2] rpc.svcgssd: Add a configure switch to disable building the daemon Steve Dickson
2014-11-05 2:56 ` NeilBrown
2014-11-05 16:17 ` Steve Dickson
2014-11-05 19:45 ` NeilBrown [this message]
2014-09-23 16:21 ` [PATCH 2/2] nfs-service: Added gssproxy support Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106064514.4b8fd215@notabene.brown \
--to=neilb@suse.de \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox