From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@primarydata.com>
Cc: trond.myklebust@primarydata.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/3] sunrpc: new tracepoints for call/reply tracking
Date: Thu, 6 Nov 2014 15:20:09 -0500 [thread overview]
Message-ID: <20141106202009.GE22638@fieldses.org> (raw)
In-Reply-To: <1414520654-1606-1-git-send-email-jlayton@primarydata.com>
On Tue, Oct 28, 2014 at 02:24:11PM -0400, Jeff Layton wrote:
> These patches add some tracepoints that I recently used when tracking
> down the hang that Christoph reported recently. At this point, I still
> haven't followed the trail to completion, but I think the problem is
> not likely to be in the RPC code.
>
> Please consider these for v3.19? Some of these are for client RPC and
> some for server-side. I'll assume that Trond will merge these, but
> review by others would be appreciated as well.
Looks fine to me, thanks, I'll assume Trond's applying all three unless
I hear otherwise.
(Separate issue: the server-side rpc dprintk's need review: they're much
too frequent to be useful, I think.)
--b.
>
> Jeff Layton (3):
> sunrpc: add some tracepoints in svc_rqst handling functions
> sunrpc: add new tracepoints in xprt handling code
> sunrpc: add tracepoints in xs_tcp_data_recv
>
> include/linux/sunrpc/xprtsock.h | 59 +++++++++++++++
> include/trace/events/sunrpc.h | 160 ++++++++++++++++++++++++++++++++++++++++
> net/sunrpc/svc.c | 21 +++---
> net/sunrpc/svc_xprt.c | 31 +++++---
> net/sunrpc/xprt.c | 9 ++-
> net/sunrpc/xprtsock.c | 69 +++--------------
> 6 files changed, 269 insertions(+), 80 deletions(-)
>
> --
> 1.9.3
>
next prev parent reply other threads:[~2014-11-06 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 18:24 [PATCH 0/3] sunrpc: new tracepoints for call/reply tracking Jeff Layton
2014-10-28 18:24 ` [PATCH 1/3] sunrpc: add some tracepoints in svc_rqst handling functions Jeff Layton
2014-10-28 18:24 ` [PATCH 2/3] sunrpc: add new tracepoints in xprt handling code Jeff Layton
2014-10-28 18:24 ` [PATCH 3/3] sunrpc: add tracepoints in xs_tcp_data_recv Jeff Layton
2014-11-06 20:20 ` J. Bruce Fields [this message]
2014-11-06 21:58 ` [PATCH 0/3] sunrpc: new tracepoints for call/reply tracking Jeff Layton
2014-11-07 16:05 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106202009.GE22638@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox