From: Christoph Hellwig <hch@infradead.org>
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: libtirpc-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/9] Avoid use of internal glibc sys/cdefs.h header
Date: Tue, 16 Dec 2014 00:55:32 -0800 [thread overview]
Message-ID: <20141216085532.GA4003@infradead.org> (raw)
In-Reply-To: <1418718540-13667-4-git-send-email-ncopa@alpinelinux.org>
On Tue, Dec 16, 2014 at 09:28:54AM +0100, Natanael Copa wrote:
> This header was never intended to be used by programs.
>
> Expand the macros used, __BEGIN_CDECLS, __END_CDECLS
Keeping __BEGIN_DECLS/__END_DECLS instead of the ifdef hell sounds
sensible, I'd suggest to just provide them if they don't exist.
Note that these are BSDishms, and not glibcisms, and used fairly widely,
so adding them to musl might be a good idea.
> The __THROW macro is a non-portable hint for optimization so we simply
> remove those.
These are important for C++, so please provide a defintion if not
present.
Against it would be useful if musl provided it.
next prev parent reply other threads:[~2014-12-16 8:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 8:28 [PATCH 0/9] Cleanups and fixes for musl libc Natanael Copa
2014-12-16 8:28 ` [PATCH 1/9] Replace INSTALL symlink with a copy of the file Natanael Copa
2014-12-16 8:28 ` [PATCH 2/9] Provide getrpcbynumber and getrpcbyname if those are missing Natanael Copa
2014-12-16 8:28 ` [PATCH 3/9] Avoid use of internal glibc sys/cdefs.h header Natanael Copa
2014-12-16 8:55 ` Christoph Hellwig [this message]
2014-12-16 8:28 ` [PATCH 4/9] Add configure option to disable DES authentication Natanael Copa
2014-12-16 8:28 ` [PATCH 5/9] Fix compile error: 'IPPORT_RESERVED' undeclared Natanael Copa
2014-12-16 8:28 ` [PATCH 6/9] Define struct rpcent on non GNU libc Natanael Copa
2014-12-16 8:28 ` [PATCH 7/9] Include string.h for memset Natanael Copa
2014-12-16 8:28 ` [PATCH 8/9] Fix location of various standard header includes Natanael Copa
2014-12-16 8:29 ` [PATCH 9/9] Add a HACKING file which tells where to send patches Natanael Copa
2015-04-23 16:55 ` [Libtirpc-devel] [PATCH 0/9] Cleanups and fixes for musl libc Steve Dickson
2015-04-23 21:51 ` Bernhard Reutner-Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216085532.GA4003@infradead.org \
--to=hch@infradead.org \
--cc=libtirpc-devel@lists.sourceforge.net \
--cc=linux-nfs@vger.kernel.org \
--cc=ncopa@alpinelinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox