Linux NFS development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jeff.layton@primarydata.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-nfs@vger.kernel.org
Subject: Re: nfsd use after free in 4.0-rc
Date: Mon, 16 Mar 2015 04:46:48 -0700	[thread overview]
Message-ID: <20150316114648.GA7432@infradead.org> (raw)
In-Reply-To: <20150315180811.02847842@tlielax.poochiereds.net>

On Sun, Mar 15, 2015 at 06:08:11PM -0400, Jeff Layton wrote:
> Could you run gdb against nfsd.ko and do a:
> 
>     list *(nfsd4_process_open2+0x1de)
> 
> I'd be interesting to see where it crashed. My suspicion would be
> trying to lock the cl->cl_lock, but I can't tell for sure (and from
> where).

That's deep inside the spinlock assembly code, but if I got back far
enough I get here:

(gdb) l *(nfsd4_process_open2+0x1c6)
0xffffffff813c6026 is in nfsd4_process_open2
(../fs/nfsd/nfs4state.c:3238).
3233		stp->st_stateowner = nfs4_get_stateowner(&oo->oo_owner);
3234		get_nfs4_file(fp);
3235		stp->st_stid.sc_file = fp;
3236		stp->st_access_bmap = 0;
3237		stp->st_deny_bmap = 0;
3238		stp->st_openstp = NULL;
3239		spin_lock(&oo->oo_owner.so_client->cl_lock);
3240		list_add(&stp->st_perstateowner, &oo->oo_owner.so_stateids);
3241		spin_lock(&fp->fi_lock);
3242		list_add(&stp->st_perfile, &fp->fi_stateids);

  reply	other threads:[~2015-03-16 11:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-15 12:56 nfsd use after free in 4.0-rc Christoph Hellwig
2015-03-15 22:08 ` Jeff Layton
2015-03-16 11:46   ` Christoph Hellwig [this message]
2015-03-16 12:20     ` Jeff Layton
2015-03-16 12:27       ` Christoph Hellwig
2015-03-16 16:19         ` J. Bruce Fields
2015-03-16 16:53           ` Jeff Layton
2015-03-16 17:10             ` J. Bruce Fields
2015-03-16 17:37               ` Jeff Layton
2015-03-16 15:58     ` J. Bruce Fields
2015-03-16 18:28       ` Christoph Hellwig
2015-03-21 14:06         ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316114648.GA7432@infradead.org \
    --to=hch@infradead.org \
    --cc=jeff.layton@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox