From: Christoph Hellwig <hch@lst.de>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: Christoph Hellwig <hch@lst.de>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-nfs@vger.kernel.org
Subject: Re: panic on 4.20 server exporting xfs filesystem
Date: Mon, 30 Mar 2015 18:44:53 +0200 [thread overview]
Message-ID: <20150330164453.GA2927@lst.de> (raw)
In-Reply-To: <20150327105029.615354f3@tlielax.poochiereds.net>
On Fri, Mar 27, 2015 at 10:50:29AM -0400, Jeff Layton wrote:
>
> Taking a quick look, the ->done routines look a little suspicious to me
> anyway. AFAICT, the pc_decode routines for the callbacks always return
> a Linux errno, not a nfsstat4, and that's what should end up in
> tk_status.
Only for errors where nfs_cb_stat_to_errno knowns how to translate
them, which aren't those we're worried about here.
However this partial translation looks really suspiios to me, I'd
really wish we could have a linux tk_status, and then an NFS-specific
way to transfer the errno. I'd also love to have a new __bitwise
type so that we can ensure NFS errnos are used properly.
next prev parent reply other threads:[~2015-03-30 16:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 22:10 panic on 4.20 server exporting xfs filesystem J. Bruce Fields
2015-03-03 22:44 ` Dave Chinner
2015-03-04 2:08 ` J. Bruce Fields
2015-03-04 4:41 ` Dave Chinner
2015-03-05 13:19 ` Christoph Hellwig
2015-03-05 15:21 ` J. Bruce Fields
2015-03-08 13:08 ` Tom Haynes
2015-03-04 15:54 ` J. Bruce Fields
2015-03-04 22:09 ` Dave Chinner
2015-03-04 22:27 ` J. Bruce Fields
2015-03-04 22:45 ` Dave Chinner
2015-03-04 22:49 ` Eric Sandeen
2015-03-04 22:56 ` Dave Chinner
2015-03-05 4:08 ` J. Bruce Fields
2015-03-05 13:17 ` Christoph Hellwig
2015-03-05 15:01 ` J. Bruce Fields
2015-03-05 17:02 ` J. Bruce Fields
2015-03-05 20:47 ` J. Bruce Fields
2015-03-05 20:59 ` Dave Chinner
2015-03-06 20:47 ` J. Bruce Fields
2015-03-19 17:27 ` Christoph Hellwig
2015-03-19 18:47 ` J. Bruce Fields
2015-03-20 6:49 ` Christoph Hellwig
2015-03-08 15:30 ` Christoph Hellwig
2015-03-09 19:45 ` J. Bruce Fields
2015-03-20 4:06 ` Kinglong Mee
2015-03-20 6:50 ` Christoph Hellwig
2015-03-20 7:56 ` [PATCH] NFSD: Fix infinite loop in nfsd4_cb_layout_fail() Kinglong Mee
2015-03-15 12:58 ` panic on 4.20 server exporting xfs filesystem Christoph Hellwig
2015-03-16 14:27 ` J. Bruce Fields
2015-03-17 10:30 ` Christoph Hellwig
2015-03-18 10:50 ` Christoph Hellwig
2015-03-27 10:41 ` Christoph Hellwig
2015-03-27 14:50 ` Jeff Layton
2015-03-30 16:44 ` Christoph Hellwig [this message]
2015-03-27 15:13 ` J. Bruce Fields
2015-04-26 16:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330164453.GA2927@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).