From: Sergei Zviagintsev <sergei@s15v.net>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfs: Fix unused variable build warning when CONFIG_SUNRPC_DEBUG is not set
Date: Thu, 16 Apr 2015 00:06:14 +0300 [thread overview]
Message-ID: <20150415210614.GE8572@localhost.localdomain> (raw)
In-Reply-To: <1429039169.27492.25.camel@x220>
Hi Paul,
On Tue, Apr 14, 2015 at 09:19:29PM +0200, Paul Bolle wrote:
> On Tue, 2015-04-14 at 01:06 +0300, Sergei Zviagintsev wrote:
> > Commit f52cbe4c9838 ("nfs: generic_write_checks() shouldn't be done on
> > swapout...") caused unused variable build warning in fs/nfs/file.c
> > when CONFIG_SUNRPC_DEBUG is not set as pos variable is used only in
> > dprintk() call. Fix it.
>
> Would that warning be:
> fs/nfs/file.c: In function ‘nfs_file_write’:
> fs/nfs/file.c:677:9: warning: unused variable ‘pos’ [-Wunused-variable]
> loff_t pos = iocb->ki_pos;
> ^
>
> Please add the warning you fix in the commit explanation. Doing that
> might save other people the trouble of doing the work you already did.
> Because then basically all they need to do is a web search or a "git log
> --grep" for (parts of) that messages.
Thank you for advice, I missed that. However I see that this warning is
fixed already in Al Viro's vfs repo, so this patch is irrelevant.
prev parent reply other threads:[~2015-04-15 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 22:06 [PATCH] nfs: Fix unused variable build warning when CONFIG_SUNRPC_DEBUG is not set Sergei Zviagintsev
2015-04-14 19:19 ` Paul Bolle
2015-04-15 21:06 ` Sergei Zviagintsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415210614.GE8572@localhost.localdomain \
--to=sergei@s15v.net \
--cc=anna.schumaker@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).