From: Tejun Heo <tj@kernel.org>
To: Jeff Layton <jeff.layton@primarydata.com>
Cc: Benjamin Coddington <bcodding@redhat.com>,
Shawn Bohrer <shawn.bohrer@gmail.com>,
linux-nfs@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, mayoff@rgmadvisors.com,
fsorenso@redhat.com
Subject: Re: NFS Freezer and stuck tasks
Date: Sat, 2 May 2015 22:03:10 -0400 [thread overview]
Message-ID: <20150503020310.GH1949@htj.duckdns.org> (raw)
In-Reply-To: <20150501191741.17bed93c@tlielax.poochiereds.net>
Hey, Jeff.
On Fri, May 01, 2015 at 07:17:41PM -0400, Jeff Layton wrote:
> > Sorry for the noise, and self-reply.. Looks like there's additional context
> > here: http://marc.info/?t=136761512100007&r=1&w=2
> >
> > Due to a number of locking problems the answer to this problem is likely to
> > be "don't do that" for now.
Unfortunately, cgroup freezer is currently inherently broken. As it
currently stands, the situation is - if it works for certain use
cases, great; otherwise, don't do that.
...
> My memory is vague, but Tejun (cc'ed) and I discussed this a couple of
> years or so ago and the tentative idea at the time was to teach the
> NFS and RPC code to return a particular error akin to ERESTARTSYS
> (EFREEZE?) when a freeze event comes in and we haven't yet sent an RPC
> call.
The idea is that freezing should be essentially identical to how
SIGSTOP is handled when viewed from kernel side.
> The idea was to teach the ptrace layer to watch for this error and
> freeze at that point and then to reissue the syscall after resume. All
> of that's a non-trivial task though, as knowledge of this would need to
> be plumbed all the way through the stack down to the RPC layer.
So, if nfs can abort and return to userland on sigpending, the task
will be able to finish quckly; otherwise, it'd have to wait till nfs
finishes.
Thanks.
--
tejun
prev parent reply other threads:[~2015-05-03 2:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 22:00 NFS Freezer and stuck tasks Shawn Bohrer
2015-05-01 20:56 ` Benjamin Coddington
2015-05-01 21:10 ` Benjamin Coddington
2015-05-01 21:18 ` Shawn Bohrer
2015-05-01 23:17 ` Jeff Layton
2015-05-03 2:03 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150503020310.GH1949@htj.duckdns.org \
--to=tj@kernel.org \
--cc=bcodding@redhat.com \
--cc=fsorenso@redhat.com \
--cc=jeff.layton@primarydata.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mayoff@rgmadvisors.com \
--cc=shawn.bohrer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).