From: Mike Frysinger <vapier@gentoo.org>
To: Steve Dickson <SteveD@redhat.com>
Cc: Thorsten Kukuk <kukuk@suse.de>,
libtirpc-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org
Subject: Re: [PATCH V2] Fix Build w/gssapi disabled
Date: Thu, 7 May 2015 22:03:22 -0400 [thread overview]
Message-ID: <20150508020322.GF30924@vapier> (raw)
In-Reply-To: <554BC9F3.6020005@RedHat.com>
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
On 07 May 2015 16:24, Steve Dickson wrote:
> --- /dev/null
> +++ b/tirpc/tirpc-features.h.in
> @@ -0,0 +1,10 @@
> +#ifndef _TIRPC_FEATURES_H
> +#define _TIRPC_FEATURES_H
> +
> +/* Define to 1 if DES authentication is enabled */
> +#undef HAVE_AUTHDES
> +
> +/* Define to 1 if GSSAPI is enabled */
> +#undef HAVE_GSSAPI
> +
> +#endif /* _TIRPC_FEATURES_H */
it is dangerous to export raw HAVE_xxx defines -- it can break packages that
use autotools themselves. they need an appropriate prefix like RPC_xxx or
TIRPC_xxx.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-08 2:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 7:19 [PATCH libtirpc] fix build w/gssapi disabled Mike Frysinger
2015-05-07 7:40 ` [Libtirpc-devel] " Thorsten Kukuk
2015-05-07 8:23 ` Mike Frysinger
2015-05-07 8:51 ` Thorsten Kukuk
2015-05-07 11:52 ` Thorsten Kukuk
2015-05-07 15:12 ` Mike Frysinger
2015-05-07 15:24 ` Steve Dickson
2015-05-07 15:38 ` Steve Dickson
2015-05-07 16:33 ` Thorsten Kukuk
2015-05-07 16:55 ` Steve Dickson
2015-05-07 18:12 ` Thorsten Kukuk
2015-05-07 20:04 ` Steve Dickson
2015-05-07 20:12 ` Steve Dickson
2015-05-07 20:24 ` [PATCH V2] Fix Build " Steve Dickson
2015-05-08 2:03 ` Mike Frysinger [this message]
2015-05-08 8:17 ` Thorsten Kukuk
2015-05-08 21:27 ` Steve Dickson
2015-05-08 22:34 ` Thorsten Kukuk
2015-05-08 3:33 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508020322.GF30924@vapier \
--to=vapier@gentoo.org \
--cc=SteveD@redhat.com \
--cc=kukuk@suse.de \
--cc=libtirpc-devel@lists.sourceforge.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).