From: Christoph Hellwig <hch@infradead.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: hch@infradead.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: Clean up bc_send()
Date: Mon, 11 May 2015 00:16:34 -0700 [thread overview]
Message-ID: <20150511071634.GA31452@infradead.org> (raw)
In-Reply-To: <20150507232028.2092.78506.stgit@manet.1015granger.net>
On Thu, May 07, 2015 at 07:20:28PM -0400, Chuck Lever wrote:
> Clean up: Merge bc_svc.c into backchannel_rqst.c, and adopt a more
> consistent naming scheme for bc_send().
Seems like a bit of an odd choise as none of the callchain bc_send
is in really touches backchannel_rqst.c.
How about just killing bc_send() and open coding it in bc_svc_process?
And while we're at it - bc_svc_process seems totally generic RPC
code that might want to be moved to net/sunrpc and converted to
a workqueue.
next prev parent reply other threads:[~2015-05-11 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 23:20 [PATCH] SUNRPC: Clean up bc_send() Chuck Lever
2015-05-11 7:16 ` Christoph Hellwig [this message]
2015-05-11 13:22 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511071634.GA31452@infradead.org \
--to=hch@infradead.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox