From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>,
linux-nfs@vger.kernel.org,
Andreas Gruenbacher <agruenba@redhat.com>
Subject: Re: [PATCH v2] nfsd: Disable NFSv2 timestamp workaround for NFSv3+
Date: Tue, 12 May 2015 15:17:08 -0400 [thread overview]
Message-ID: <20150512191708.GA8980@fieldses.org> (raw)
In-Reply-To: <20150511122611.GA5732@lst.de>
On Mon, May 11, 2015 at 02:26:11PM +0200, Christoph Hellwig wrote:
> On Sat, May 09, 2015 at 12:37:57AM +0200, Andreas Gruenbacher wrote:
> > NFSv2 can set the atime and/or mtime of a file to specific timestamps but not
> > to the server's current time. To implement the equivalent of utimes("file",
> > NULL), it uses a heuristic.
> >
> > NFSv3 and later do support setting the atime and/or mtime to the server's
> > current time directly. The NFSv2 heuristic is still enabled, and causes
> > timestamps to be set wrong sometimes.
> >
> > Fix this by moving the heuristic into the NFSv2 specific code. We can leave it
> > out of the create code path: the owner can always set timestamps arbitrarily,
> > and the workaround would never trigger.
> >
> > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
>
> This looks fine,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Yep, thanks, applying for 4.2.
--b.
prev parent reply other threads:[~2015-05-12 19:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 6:50 [PATCH] nfsd: Disable NFSv2 timestamp workaround for NFSv3+ Andreas Gruenbacher
2015-05-06 6:56 ` Christoph Hellwig
2015-05-06 10:12 ` Andreas Grünbacher
2015-05-07 7:53 ` Christoph Hellwig
2015-05-07 14:08 ` J. Bruce Fields
2015-05-08 22:37 ` [PATCH v2] " Andreas Gruenbacher
2015-05-08 22:50 ` Andreas Grünbacher
2015-05-11 12:27 ` Christoph Hellwig
2015-05-12 18:38 ` Andreas Grünbacher
2015-05-11 12:26 ` Christoph Hellwig
2015-05-12 19:17 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512191708.GA8980@fieldses.org \
--to=bfields@fieldses.org \
--cc=agruenba@redhat.com \
--cc=andreas.gruenbacher@gmail.com \
--cc=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).