Re: [PATCH 1/2] nfsd: Reset cb_status in nfsd4_cb_prepare() at retrying

["J. Bruce Fields" <bfields@fieldses.org>]

On Tue, Jun 02, 2015 at 06:59:19PM +0800, Kinglong Mee wrote:
> nfsd enters a infinite loop and print message per 10 seconds,
> 
> May 31 18:33:52 test-server kernel: Error sending entire callback!
> May 31 18:34:01 test-server kernel: Error sending entire callback!
> 
> It is caused by a cb_layoutreturn got error -10008 (NFS4ERR_DELAY),
> and then, the client crash, nfsd enter the infinite loop.
> 
> bc_sendto --> call_timeout --> nfsd4_cb_done --> nfsd4_cb_layout_done
>  with error -10008 --> rpc_delay(task, HZ/100) --> bc_sendto ...

How are you reproducing this?

--b.

> 
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> ---
>  fs/nfsd/nfs4callback.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> index 5694cfb..8b1ac8d 100644
> --- a/fs/nfsd/nfs4callback.c
> +++ b/fs/nfsd/nfs4callback.c
> @@ -875,6 +875,7 @@ static void nfsd4_cb_prepare(struct rpc_task *task, void *calldata)
>  	u32 minorversion = clp->cl_minorversion;
>  
>  	cb->cb_minorversion = minorversion;
> +	cb->cb_status = 0;
>  	if (minorversion) {
>  		if (!nfsd41_cb_get_slot(clp, task))
>  			return;
> -- 
> 2.4.2