linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Weston Andros Adamson <dros@primarydata.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-nfs list <linux-nfs@vger.kernel.org>
Subject: Re: blocklayout regression in "pnfs: lookup new lseg at lseg boundary"
Date: Wed, 17 Jun 2015 05:46:03 -0700	[thread overview]
Message-ID: <20150617124603.GA1199@infradead.org> (raw)
In-Reply-To: <8C6E88F8-19DB-49B1-A0A8-ADA171D113AB@primarydata.com>

On Wed, May 13, 2015 at 11:17:52AM -0400, Weston Andros Adamson wrote:
> Hey Christoph,
> 
> Sorry this got buried in my inbox :-/
> 
> -               WARN_ON_ONCE(req_start > seg_end);
> +               WARN_ON_ONCE(req_start >= seg_end);
> 
> I think you???re right, I shouldn???t have changed that WARN_ON.
> 
> It???s been a while since I looked at this, but I???m wondering if that WARN_ON
> even makes sense anymore now that we do handle multiple segments.

Are you going to send a patch for this?

      reply	other threads:[~2015-06-17 12:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-25 16:56 blocklayout regression in "pnfs: lookup new lseg at lseg boundary" Christoph Hellwig
2015-05-07  7:42 ` Christoph Hellwig
2015-05-13 15:17   ` Weston Andros Adamson
2015-06-17 12:46     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150617124603.GA1199@infradead.org \
    --to=hch@infradead.org \
    --cc=dros@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).