From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:5824 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbbFXPCH (ORCPT ); Wed, 24 Jun 2015 11:02:07 -0400 Date: Wed, 24 Jun 2015 23:00:49 +0800 From: kbuild test robot To: Trond Myklebust Cc: kbuild-all@01.org, Jeff Layton , Peng Tao , linux-nfs@vger.kernel.org Subject: [PATCH] fix ptr_ret.cocci warnings Message-ID: <20150624150049.GA60090@xian> References: <201506242346.OCI4AVtF%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <201506242346.OCI4AVtF%fengguang.wu@intel.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: fs/nfs/nfs42proc.c:191:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Fengguang Wu --- nfs42proc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/fs/nfs/nfs42proc.c +++ b/fs/nfs/nfs42proc.c @@ -188,7 +188,5 @@ int nfs42_proc_layoutstats_generic(struc nfs4_init_sequence(&data->args.seq_args, &data->res.seq_res, 0); task = rpc_run_task(&task_setup); - if (IS_ERR(task)) - return PTR_ERR(task); - return 0; + return PTR_ERR_OR_ZERO(task); }