From: Al Viro <viro@ZenIV.linux.org.uk>
To: NeilBrown <neilb@suse.com>
Cc: Kinglong Mee <kinglongmee@gmail.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Trond Myklebust <trond.myklebust@primarydata.com>
Subject: Re: [PATCH 10/10 v7] nfsd: Allows user un-mounting filesystem where nfsd exports base on
Date: Mon, 13 Jul 2015 07:08:02 +0100 [thread overview]
Message-ID: <20150713060802.GP17109@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150713160243.6173a214@noble>
On Mon, Jul 13, 2015 at 04:02:43PM +1000, NeilBrown wrote:
> I think that means we need a variant of pin_remove() which reports if
> pin->done was 0 or -1.
> If it was 0, then ->kill hasn't been called, and it won't be. So the
> caller is free to clean up how it likes (providing RCU is used for
> freeing).
Grr... What will umount(2) wait for if it comes during your cleanup?
You are putting them in the wrong order - pin_remove() is "I'm *DONE*
killing that sucker, nothing to wait for", not "move along, don't wait
for me, I've taken over killing it off".
next prev parent reply other threads:[~2015-07-13 6:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-11 12:46 [PATCH 00/10 v7] NFSD: Pin to vfsmount for nfsd exports cache Kinglong Mee
2015-07-11 12:47 ` [PATCH 01/10 v7] fs_pin: Initialize value for fs_pin explicitly Kinglong Mee
2015-07-11 12:47 ` [PATCH 02/10 v7] fs_pin: Export functions for specific filesystem Kinglong Mee
2015-07-11 12:48 ` [PATCH 03/10 v7] path: New helpers path_get_pin/path_put_unpin for path pin Kinglong Mee
2015-07-11 12:48 ` [PATCH 04/10 v7] fs: New helper legitimize_mntget() for getting a legitimize mnt Kinglong Mee
2015-07-11 12:49 ` [PATCH 05/10 v7] sunrpc: Store cache_detail in seq_file's private, directly Kinglong Mee
2015-07-11 12:49 ` [PATCH 06/10 v7] sunrpc/nfsd: Remove redundant code by exports seq_operations functions Kinglong Mee
2015-07-11 12:50 ` [PATCH 07/10 v7] sunrpc: Switch to using list_head instead single list Kinglong Mee
2015-07-11 12:54 ` Christoph Hellwig
2015-07-13 1:30 ` NeilBrown
2015-07-13 8:27 ` Kinglong Mee
2015-07-11 12:51 ` [PATCH 08/10 v7] sunrpc: New helper cache_delete_entry for deleting cache_head directly Kinglong Mee
2015-07-11 12:51 ` [PATCH 09/10 v7] sunrpc: Support get_ref/put_ref for reference change in cache_head Kinglong Mee
2015-07-11 12:52 ` [PATCH 10/10 v7] nfsd: Allows user un-mounting filesystem where nfsd exports base on Kinglong Mee
2015-07-13 3:39 ` NeilBrown
2015-07-13 4:02 ` Al Viro
2015-07-13 5:19 ` NeilBrown
2015-07-13 6:02 ` Al Viro
2015-07-13 4:20 ` NeilBrown
2015-07-13 4:45 ` Al Viro
2015-07-13 5:21 ` NeilBrown
2015-07-13 6:02 ` NeilBrown
2015-07-13 6:08 ` Al Viro [this message]
2015-07-13 6:32 ` NeilBrown
2015-07-13 6:43 ` Al Viro
2015-07-15 3:49 ` NeilBrown
2015-07-15 4:57 ` Al Viro
2015-07-15 6:51 ` NeilBrown
2015-07-24 2:05 ` NeilBrown
2015-07-27 2:28 ` Kinglong Mee
2015-07-27 2:51 ` NeilBrown
2015-07-27 3:17 ` Kinglong Mee
2015-07-15 21:07 ` J. Bruce Fields
2015-07-15 23:40 ` NeilBrown
2015-07-16 20:51 ` J. Bruce Fields
2015-07-21 21:58 ` NeilBrown
2015-07-22 15:08 ` J. Bruce Fields
2015-07-23 23:46 ` export table lookup: was " NeilBrown
2015-07-24 19:48 ` J. Bruce Fields
2015-07-25 0:40 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713060802.GP17109@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bfields@fieldses.org \
--cc=kinglongmee@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox