From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: Christoph Hellwig <hch@infradead.org>,
bfields@fieldses.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 04/18] nfsd: add a new struct file caching facility to nfsd
Date: Mon, 10 Aug 2015 01:28:07 -0700 [thread overview]
Message-ID: <20150810082807.GA28480@infradead.org> (raw)
In-Reply-To: <20150809071932.3ef4d0a2@tlielax.poochiereds.net>
> I started looking at extending the nfs4_file cache to NFSv2/3, but it's
> actually rather difficult...
>
> We traditionally haven't dealt with share/deny modes in NFSv3, so we'd
> need a mechanism to bypass all of that stuff for legacy protocols. We'd
> also have to convert that cache from one that frees objects when the
> last one is put to one that keeps them around for a bit.
>
> That also means that the v2/3 opens have to keep around extra fields
> that aren't really needed, and deal with the really godawful locking of
> the NFSv4 code.
>
> I really think this approach is a better one. We can still use this
> cache from the NFSv4 code and wiring it in shouldn't be too hard. It's
> mostly a matter of plumbing in struct nfsd_file objects where that code
> is passing around struct file objects now.
Ok. I'd still like to it wired up to NFSv4 - with my changes to make all
temporary file opens happens from nfs4_preprocess_stateid_op it should
be fairly simple.
next prev parent reply other threads:[~2015-08-10 8:28 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 13:52 [PATCH 0/9] nfsd: open file caching for v2/3 Jeff Layton
2015-07-30 13:52 ` [PATCH] nfsd: do nfs4_check_fh in nfs4_check_file instead of nfs4_check_olstateid Jeff Layton
2015-07-30 13:53 ` Jeff Layton
2015-07-30 15:51 ` Christoph Hellwig
2015-07-30 16:20 ` Jeff Layton
2015-07-30 16:34 ` Christoph Hellwig
2015-07-30 13:52 ` [PATCH 1/9] nfsd: include linux/nfs4.h in export.h Jeff Layton
2015-07-30 13:52 ` [PATCH 2/9] nfsd: move some file caching helpers to a common header Jeff Layton
2015-07-30 13:52 ` [PATCH 3/9] nfsd: convert laundry_wq to something less nfsd4 specific Jeff Layton
2015-07-31 21:32 ` J. Bruce Fields
2015-07-31 22:27 ` Jeff Layton
2015-07-30 13:52 ` [PATCH 4/9] nfsd: add a new struct file caching facility to nfsd Jeff Layton
2015-07-30 13:52 ` [PATCH 5/9] nfsd: hook up nfsd_write to the new nfsd_file cache Jeff Layton
2015-07-30 13:52 ` [PATCH 6/9] nfsd: hook up nfsd_read to the " Jeff Layton
2015-07-30 13:52 ` [PATCH 7/9] sunrpc: add a new cache_detail operation for when a cache is flushed Jeff Layton
2015-07-30 13:52 ` [PATCH 8/9] nfsd: add a ->flush routine to svc_export_cache Jeff Layton
2015-07-30 13:52 ` [PATCH 9/9] nfsd: allow the file cache expire time to be tunable Jeff Layton
2015-08-05 21:13 ` [PATCH v2 00/18] nfsd: open file caching for v2/3 Jeff Layton
2015-08-05 21:13 ` [PATCH v2 01/18] nfsd: include linux/nfs4.h in export.h Jeff Layton
2015-08-09 7:12 ` Christoph Hellwig
2015-08-05 21:13 ` [PATCH v2 02/18] nfsd: move some file caching helpers to a common header Jeff Layton
2015-08-07 15:25 ` Kinglong Mee
2015-08-07 17:07 ` Jeff Layton
2015-08-09 7:12 ` Christoph Hellwig
2015-08-05 21:13 ` [PATCH v2 03/18] nfsd: convert laundry_wq to something less nfsd4 specific Jeff Layton
2015-08-07 15:26 ` Kinglong Mee
2015-08-07 17:12 ` Jeff Layton
2015-08-09 7:14 ` Christoph Hellwig
2015-08-09 11:11 ` Jeff Layton
2015-08-10 8:26 ` Christoph Hellwig
2015-08-10 11:23 ` Jeff Layton
2015-08-10 12:10 ` Christoph Hellwig
2015-08-10 12:14 ` Jeff Layton
2015-08-10 14:33 ` J. Bruce Fields
2015-08-05 21:13 ` [PATCH v2 04/18] nfsd: add a new struct file caching facility to nfsd Jeff Layton
2015-08-07 15:28 ` Kinglong Mee
2015-08-07 17:18 ` Jeff Layton
2015-08-08 0:14 ` Kinglong Mee
2015-08-08 10:36 ` Jeff Layton
2015-08-10 11:36 ` Kinglong Mee
2015-08-09 7:17 ` Christoph Hellwig
2015-08-09 11:19 ` Jeff Layton
2015-08-10 8:28 ` Christoph Hellwig [this message]
2015-08-10 11:31 ` Jeff Layton
2015-08-05 21:13 ` [PATCH v2 05/18] nfsd: hook up nfsd_write to the new nfsd_file cache Jeff Layton
2015-08-05 21:13 ` [PATCH v2 06/18] nfsd: hook up nfsd_read to the " Jeff Layton
2015-08-07 15:29 ` Kinglong Mee
2015-08-07 17:26 ` Jeff Layton
2015-08-08 0:19 ` Kinglong Mee
2015-08-05 21:13 ` [PATCH v2 07/18] sunrpc: add a new cache_detail operation for when a cache is flushed Jeff Layton
2015-08-05 21:13 ` [PATCH v2 08/18] nfsd: add a ->flush routine to svc_export_cache Jeff Layton
2015-08-05 21:13 ` [PATCH v2 09/18] nfsd: allow the file cache expire time to be tunable Jeff Layton
2015-08-05 21:13 ` [PATCH v2 10/18] nfsd: handle NFSD_MAY_NOT_BREAK_LEASE in open file cache Jeff Layton
2015-08-05 21:13 ` [PATCH v2 11/18] nfsd: hook nfsd_commit up to the nfsd_file cache Jeff Layton
2015-08-05 21:13 ` [PATCH v2 12/18] nfsd: move include of state.h from trace.c to trace.h Jeff Layton
2015-08-09 7:18 ` Christoph Hellwig
2015-08-05 21:13 ` [PATCH v2 13/18] nfsd: add new tracepoints for nfsd_file cache Jeff Layton
2015-08-05 21:13 ` [PATCH v2 14/18] nfsd: have _fh_update take a knfsd_fh instead of a svc_fh Jeff Layton
2015-08-09 7:21 ` Christoph Hellwig
2015-08-05 21:13 ` [PATCH v2 15/18] nfsd: have set_version_and_fsid_type take a knfsd_fh instead of svc_fh Jeff Layton
2015-08-09 7:21 ` Christoph Hellwig
2015-08-05 21:13 ` [PATCH v2 16/18] nfsd: add a fh_compose_shallow Jeff Layton
2015-08-07 15:33 ` Kinglong Mee
2015-08-07 17:56 ` Jeff Layton
2015-08-07 18:24 ` Jeff Layton
2015-08-08 0:27 ` Kinglong Mee
2015-08-08 10:38 ` Jeff Layton
2015-08-05 21:13 ` [PATCH v2 17/18] nfsd: close cached files prior to a REMOVE or RENAME that would replace target Jeff Layton
2015-08-05 21:13 ` [PATCH v2 18/18] nfsd: call flush_delayed_fput from nfsd_file_close_fh Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150810082807.GA28480@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox