Re: [PATCH] nfsd/blocklayout: accept any minlength

J. Bruce Fields
2015-10-09T17:45:57Z

On Fri, Oct 09, 2015 at 07:04:00PM +0200, Christoph Hellwig wrote:
> On Fri, Oct 09, 2015 at 11:28:03AM -0400, J. Bruce Fields wrote:
> > OK, planning to apply for 4.3 just on the assumption that you know what
> > you're doing, but: I don't get it--it looks like the worst that can
> > happen here is we just reuturn LAYOUTUNAVAILABLE to LAYOUTGET.
> > Shouldn't the client then just fall back on normal NFS IO? Why the
> > hang?
>
> I've just retested with Trond's latest tree and can't reproduce the
> hang anymore. It used to fence the client due to a lack of response,
> but that might have been a different client bug that has now been fixed.

OK, makes sense.

This still looks like a harmless enough change, but is it still stable
and 4.3 material?

If it affected a released client then it's probably worth it even if
it's really a client bug. If it's just something you saw once against
an -rc1, I'd rather leave it for 4.4.

--b.