From: bfields@fieldses.org (J. Bruce Fields)
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/3] Improving rpc.gssd's debugging
Date: Mon, 9 Nov 2015 13:27:39 -0500 [thread overview]
Message-ID: <20151109182739.GC8738@fieldses.org> (raw)
In-Reply-To: <1446920050-5968-1-git-send-email-steved@redhat.com>
On Sat, Nov 07, 2015 at 01:14:07PM -0500, Steve Dickson wrote:
> Now that rpc.gssd is the critical path of every
> NFS mount, any favored mount, I thought I would
> take a crack at making the daemon a bit more
> debuggable by making the logging more readable.
>
> The first level of debugging (-v) will only log
> errors and warnings that are not normally logged.
> I'm thinking this might be a good level to run
> at a customer's site.
>
> I also thought about changing the majority of the
> printerr(0) which always log to printerr(1)s. I
> decided not to since I figured more info is
> better.
>
> Note, I didn't remove any of the messages, I just pushed
> them back to other debug levels.
>
> I trimmed down the second level of debugging (-vv)
> by again moving them back to other levels.
>
> The third level (-vvv) is basically the same.
>
> Using the fourth level (-vvvv) to enable all the logging
> that old level three did.
>
> Thoughts/Comments... A waste of a good Saturday afternoon?? ;-)
I haven't reviewed the patches, but those sound like reasonable things
to do to me.
--b.
>
> Steve Dickson (3):
> gssd: reworked first level of debugging
> gssd: log all fatal errors
> gssd: reworked second level of debugging
>
> utils/gssd/context_heimdal.c | 2 +-
> utils/gssd/context_lucid.c | 6 +++---
> utils/gssd/gssd.c | 14 +++++++-------
> utils/gssd/gssd_proc.c | 32 +++++++++++++-------------------
> utils/gssd/krb5_util.c | 28 ++++++++++++++++------------
> 5 files changed, 40 insertions(+), 42 deletions(-)
>
> --
> 2.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-09 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 18:14 [PATCH 0/3] Improving rpc.gssd's debugging Steve Dickson
2015-11-07 18:14 ` [PATCH 1/3] gssd: reworked first level of debugging Steve Dickson
2015-11-07 18:14 ` [PATCH 2/3] gssd: log all fatal errors Steve Dickson
2015-11-07 18:14 ` [PATCH 3/3] gssd: reworked second level of debugging Steve Dickson
2015-11-09 18:27 ` J. Bruce Fields [this message]
2015-11-16 20:59 ` [PATCH 0/3] Improving rpc.gssd's debugging Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109182739.GC8738@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox