From: Christoph Hellwig <hch@lst.de>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Kinglong Mee <kinglongmee@gmail.com>
Subject: Re: [RFC PATCH 2/2] nfsd: give up on CB_LAYOUTRECALLs after two lease periods
Date: Tue, 8 Dec 2015 16:21:23 +0100 [thread overview]
Message-ID: <20151208152123.GB4035@lst.de> (raw)
In-Reply-To: <1449577428-13181-3-git-send-email-jeff.layton@primarydata.com>
On Tue, Dec 08, 2015 at 07:23:48AM -0500, Jeff Layton wrote:
> Have the CB_LAYOUTRECALL code treat NFS4_OK and NFS4ERR_DELAY returns
> equivalently. Change the code to periodically resend CB_LAYOUTRECALLS
> until the ls_layouts list is empty or the client returns a different
> error code.
>
> If we go for two lease periods without the list being emptied or the
> client sending a hard error, then we give up and clean out the list
> anyway.
This looks reasonable to me, but I'll need to actually test it
before giving an ACK.
Btw, it seems like the delegation and layoutrecall code would benefit
from some more code sharing for timeouts. For example delegation
returns currently don't support NFS4ERR_DELAY at all.
next prev parent reply other threads:[~2015-12-08 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 12:23 [RFC PATCH 0/2] nfsd: clean up CB_LAYOUTRECALL handling Jeff Layton
2015-12-08 12:23 ` [RFC PATCH 1/2] nfsd: don't hold ls_mutex across a layout recall Jeff Layton
2015-12-08 15:19 ` Christoph Hellwig
2015-12-08 12:23 ` [RFC PATCH 2/2] nfsd: give up on CB_LAYOUTRECALLs after two lease periods Jeff Layton
2015-12-08 15:21 ` Christoph Hellwig [this message]
2015-12-08 15:46 ` Jeff Layton
2015-12-10 16:31 ` Christoph Hellwig
2015-12-22 13:25 ` Christoph Hellwig
2016-01-08 19:36 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208152123.GB4035@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).