From: Christoph Hellwig <hch@lst.de>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: Christoph Hellwig <hch@lst.de>,
bfields@fieldses.org, linux-nfs@vger.kernel.org,
Kinglong Mee <kinglongmee@gmail.com>
Subject: Re: [RFC PATCH 2/2] nfsd: give up on CB_LAYOUTRECALLs after two lease periods
Date: Thu, 10 Dec 2015 17:31:02 +0100 [thread overview]
Message-ID: <20151210163102.GA29300@lst.de> (raw)
In-Reply-To: <20151208104610.6e3eae3f@tlielax.poochiereds.net>
On Tue, Dec 08, 2015 at 10:46:10AM -0500, Jeff Layton wrote:
> > This looks reasonable to me, but I'll need to actually test it
> > before giving an ACK.
> >
>
> Please do, I don't have a good way to test this at the moment...
Looks like the baseline got broken once again, so I'll need some time
to track that down first.
> > Btw, it seems like the delegation and layoutrecall code would benefit
> > from some more code sharing for timeouts. For example delegation
> > returns currently don't support NFS4ERR_DELAY at all.
>
> Yes...
>
> I also wonder -- are we handling revoked layouts correctly? Shouldn't
> we be handling revoked layouts like we would a revoked delegation? Stop
> allowing the stateid to be used and morph it appropriately so that a
> TEST_STATEID against it gives you an error?
Probably, but I'd need to take a deeper look at this.
next prev parent reply other threads:[~2015-12-10 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 12:23 [RFC PATCH 0/2] nfsd: clean up CB_LAYOUTRECALL handling Jeff Layton
2015-12-08 12:23 ` [RFC PATCH 1/2] nfsd: don't hold ls_mutex across a layout recall Jeff Layton
2015-12-08 15:19 ` Christoph Hellwig
2015-12-08 12:23 ` [RFC PATCH 2/2] nfsd: give up on CB_LAYOUTRECALLs after two lease periods Jeff Layton
2015-12-08 15:21 ` Christoph Hellwig
2015-12-08 15:46 ` Jeff Layton
2015-12-10 16:31 ` Christoph Hellwig [this message]
2015-12-22 13:25 ` Christoph Hellwig
2016-01-08 19:36 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210163102.GA29300@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).