From: Christoph Hellwig <hch@infradead.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Sagi Grimberg <sagig@dev.mellanox.co.il>,
anna.schumaker@netapp.com, linux-rdma@vger.kernel.org,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v3 04/11] xprtrdma: Move struct ib_send_wr off the stack
Date: Wed, 16 Dec 2015 07:11:15 -0800 [thread overview]
Message-ID: <20151216151115.GA16905@infradead.org> (raw)
In-Reply-To: <F2E992ED-2698-43DE-B7C5-4F02DA75AE42@oracle.com>
On Wed, Dec 16, 2015 at 10:06:33AM -0500, Chuck Lever wrote:
> > Would it make sense to unionize these as they are guaranteed not to
> > execute together? Some people don't like this sort of savings.
>
> I dislike unions because they make the code that uses
> them less readable. I can define macros to help that,
> but sigh! OK.
Shouldn't be an issue with transparent unions these days:
union {
struct ib_reg_wr fr_regwr;
struct ib_send_wr fr_invwr;
};
next prev parent reply other threads:[~2015-12-16 15:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 21:17 [PATCH v3 00/11] NFS/RDMA client patches for 4.5 Chuck Lever
2015-12-14 21:17 ` [PATCH v3 01/11] xprtrdma: Fix additional uses of spin_lock_irqsave(rb_lock) Chuck Lever
2015-12-14 21:17 ` [PATCH v3 02/11] xprtrdma: xprt_rdma_free() must not release backchannel reqs Chuck Lever
2015-12-14 21:18 ` [PATCH v3 03/11] xprtrdma: Disable RPC/RDMA backchannel debugging messages Chuck Lever
2015-12-14 21:18 ` [PATCH v3 04/11] xprtrdma: Move struct ib_send_wr off the stack Chuck Lever
2015-12-16 14:00 ` Sagi Grimberg
2015-12-16 15:06 ` Chuck Lever
2015-12-16 15:11 ` Christoph Hellwig [this message]
2015-12-16 15:13 ` Chuck Lever
2015-12-16 15:17 ` Christoph Hellwig
2015-12-14 21:18 ` [PATCH v3 05/11] xprtrdma: Introduce ro_unmap_sync method Chuck Lever
2015-12-14 21:18 ` [PATCH v3 06/11] xprtrdma: Add ro_unmap_sync method for FRWR Chuck Lever
2015-12-16 13:57 ` Sagi Grimberg
2015-12-16 15:09 ` Chuck Lever
2015-12-14 21:18 ` [PATCH v3 07/11] xprtrdma: Add ro_unmap_sync method for FMR Chuck Lever
2015-12-14 21:19 ` [PATCH v3 08/11] xprtrdma: Add ro_unmap_sync method for all-physical registration Chuck Lever
2015-12-14 21:19 ` [PATCH v3 09/11] SUNRPC: Introduce xprt_commit_rqst() Chuck Lever
2015-12-16 13:48 ` Anna Schumaker
2015-12-16 15:12 ` Chuck Lever
2015-12-14 21:19 ` [PATCH v3 10/11] xprtrdma: Invalidate in the RPC reply handler Chuck Lever
2015-12-14 21:19 ` [PATCH v3 11/11] xprtrdma: Revert commit e7104a2a9606 ('xprtrdma: Cap req_cqinit') Chuck Lever
2015-12-15 19:37 ` [PATCH v3 00/11] NFS/RDMA client patches for 4.5 Anna Schumaker
2015-12-16 12:11 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151216151115.GA16905@infradead.org \
--to=hch@infradead.org \
--cc=anna.schumaker@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagig@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox