linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Malahal Naineni <malahal@us.ibm.com>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: Steve Dickson <SteveD@redhat.com>,
	linux-nfs@vger.kernel.org,
	"J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [PATCH] Ignore whitespace at the beginning of option tags
Date: Thu, 4 Feb 2016 17:29:56 -0600	[thread overview]
Message-ID: <20160204232956.GA1290@us.ibm.com> (raw)
In-Reply-To: <alpine.OSX.2.19.9992.1602030655230.16954@planck.local>

Sorry Steve, Ben is right. It is based on
"git://git.linux-nfs.org/projects/steved/libnfsidmap.git"

Do I need to re-clone my repo with something else?

Regards, Malahal.

Benjamin Coddington [bcodding@redhat.com] wrote:
> On Tue, 2 Feb 2016, Steve Dickson wrote:
> >
> > On 01/28/2016 05:38 PM, Malahal Naineni wrote:
> > > The following should work now:
> > >
> > > [General]
> > > 	Domain = local.domain.edu
> > >
> > > Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
> > > ---
> > >  cfg.c | 9 ++++++++-
> > Ok.. I give... :-) What is this patch relative to? There is
> > a conf_parse_line() in support/nfs/conffile.c but there
> > is no cfg.c file in nfs-utils... and this patch does
> > not apply...
> 
> This is for libnfsidap..  cc-ing Bruce.
> 
> Ben
> 
> > >  1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/cfg.c b/cfg.c
> > > index c615d24..e0ab839 100644
> > > --- a/cfg.c
> > > +++ b/cfg.c
> > > @@ -210,6 +210,7 @@ static void
> > >  conf_parse_line (int trans, char *line, size_t sz)
> > >  {
> > >    char *val;
> > > +  char *tag;
> > >    size_t i;
> > >    int j;
> > >    static char *section = 0;
> > > @@ -262,8 +263,14 @@ conf_parse_line (int trans, char *line, size_t sz)
> > >  	/* Skip trailing whitespace, if any */
> > >  	for (j = sz - (val - line) - 1; j > 0 && isspace (val[j]); j--)
> > >  	  val[j] = '\0';
> > > +
> > > +	/* Skip beginning white space */
> > > +	tag = line;
> > > +	while (isspace(*tag))
> > > +		tag++;
> > > +
> > >  	/* XXX Perhaps should we not ignore errors?  */
> > > -	conf_set (trans, section, line, val, 0, 0);
> > > +	conf_set (trans, section, tag, val, 0, 0);
> > >  	return;
> > >        }
> > >
> > >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2016-02-04 23:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 22:38 [PATCH] Ignore whitespace at the beginning of option tags Malahal Naineni
2016-02-02 15:24 ` Steve Dickson
2016-02-03 11:58   ` Benjamin Coddington
2016-02-04 23:29     ` Malahal Naineni [this message]
2016-02-09 16:00       ` Steve Dickson
2016-02-09 16:13         ` J. Bruce Fields
2016-02-11 18:02         ` Malahal Naineni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160204232956.GA1290@us.ibm.com \
    --to=malahal@us.ibm.com \
    --cc=SteveD@redhat.com \
    --cc=bcodding@redhat.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).