linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bfields@fieldses.org (J. Bruce Fields)
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v3 01/10] svcrdma: Do not write xdr_buf::tail in a Write chunk
Date: Mon, 22 Feb 2016 13:32:11 -0500	[thread overview]
Message-ID: <20160222183211.GA22270@fieldses.org> (raw)
In-Reply-To: <20160218174353.12825.14732.stgit@klimt.1015granger.net>

On Thu, Feb 18, 2016 at 12:43:53PM -0500, Chuck Lever wrote:
> The fix is to send only the contents of the xdr_buf's page list in
> a Write chunk.

This isn't quite right either.  A large-enough non-readlike reply will
use the page list if that's the only way to fit the reply.

You might be able to hit such cases, for example, using nfs4_getfacl on
a file with a sufficiently large ACL.

--b.

  reply	other threads:[~2016-02-22 18:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 17:43 [PATCH v3 00/10] NFS/RDMA server patches for v4.6 Chuck Lever
2016-02-18 17:43 ` [PATCH v3 01/10] svcrdma: Do not write xdr_buf::tail in a Write chunk Chuck Lever
2016-02-22 18:32   ` J. Bruce Fields [this message]
2016-02-22 18:35     ` Chuck Lever
2016-02-22 18:39       ` Chuck Lever
2016-02-18 17:44 ` [PATCH v3 02/10] nfsd: Lower NFSv4.1 callback message size limit Chuck Lever
2016-02-18 17:53   ` Chuck Lever
2016-02-18 17:44 ` [PATCH v3 03/10] svcrdma: svc_rdma_post_recv() should close connection on error Chuck Lever
2016-02-18 17:44 ` [PATCH v3 04/10] rpcrdma: Add RPCRDMA_HDRLEN_ERR Chuck Lever
2016-02-18 17:44 ` [PATCH v3 05/10] svcrdma: Make RDMA_ERROR messages work Chuck Lever
2016-02-18 17:44 ` [PATCH v3 06/10] svcrdma: Use correct XID in error replies Chuck Lever
2016-02-18 17:44 ` [PATCH v3 07/10] svcrdma: Hook up the logic to return ERR_CHUNK Chuck Lever
2016-02-18 17:44 ` [PATCH v3 08/10] svcrdma: Remove close_out exit path Chuck Lever
2016-02-18 17:44 ` [PATCH v3 09/10] svcrdma: Use new CQ API for RPC-over-RDMA server receive CQs Chuck Lever
2016-02-18 17:45 ` [PATCH v3 10/10] svcrdma: Use new CQ API for RPC-over-RDMA server send CQs Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160222183211.GA22270@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).