From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Kinglong Mee <kinglongmee@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
Peng Tao <tao.peng@primarydata.com>
Subject: Re: [PATCH] nfs/blocklayout: make sure making a aligned read request
Date: Mon, 21 Mar 2016 08:30:14 -0700 [thread overview]
Message-ID: <20160321153014.GA18948@infradead.org> (raw)
In-Reply-To: <CAHQdGtQWxv1vzC_o8x3JSFyW3tMYihF1rcmFGBsGEpddLabejA@mail.gmail.com>
On Wed, Mar 16, 2016 at 03:41:06PM -0400, Trond Myklebust wrote:
> Christoph, does Kinglong's explanation satisfy your concerns, or are
> there still unresolved differences that should prevent me from taking
> this patch?
I still don't think it's the right thing to do, but I don't have time
time to debug the issue fully myself. Let's take the patch for now
as it should be less harmful than not having it.
next prev parent reply other threads:[~2016-03-21 15:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 13:51 [PATCH] nfs/blocklayout: make sure making a aligned read request Kinglong Mee
2016-02-29 9:57 ` Christoph Hellwig
2016-02-29 12:00 ` Kinglong Mee
2016-02-29 13:34 ` Christoph Hellwig
2016-03-01 12:35 ` Kinglong Mee
2016-03-16 19:41 ` Trond Myklebust
2016-03-21 15:30 ` Christoph Hellwig [this message]
2016-03-21 18:27 ` William Dauchy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321153014.GA18948@infradead.org \
--to=hch@infradead.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=tao.peng@primarydata.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).