linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Junichi Nomura <j-nomura@ce.jp.nec.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [REGRESSION 4.6-rc1] NFS mounts (using autofs) failing
Date: Tue, 29 Mar 2016 15:02:44 +0100	[thread overview]
Message-ID: <20160329140244.GV17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <56FA62FB.1080506@broadcom.com>

On Tue, Mar 29, 2016 at 01:11:55PM +0200, Arend Van Spriel wrote:
> Hi Al,
> 
> Moved to 4.6-rc1 and found NFS mounts were failing moving to the new
> kernel. The NFS mounts are done using autofs. Below is the bisect log
> and attached the kernel .config file. Let me know if you need any other
> information.

AFAICS, it's the same one that got reported yesterday by Junichi Nomura.
Folks, could you check if the delta below fixes it?

diff --git a/fs/namei.c b/fs/namei.c
index 3498d53..0d80c72 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1740,15 +1740,17 @@ static int walk_component(struct nameidata *nd, int flags)
 					  nd->flags);
 		if (IS_ERR(path.dentry))
 			return PTR_ERR(path.dentry);
-		if (unlikely(d_is_negative(path.dentry))) {
-			dput(path.dentry);
-			return -ENOENT;
-		}
+
 		path.mnt = nd->path.mnt;
 		err = follow_managed(&path, nd);
 		if (unlikely(err < 0))
 			return err;
 
+		if (unlikely(d_is_negative(path.dentry))) {
+			path_to_nameidata(&path, nd);
+			return -ENOENT;
+		}
+
 		seq = 0;	/* we are already out of RCU mode */
 		inode = d_backing_inode(path.dentry);
 	}

       reply	other threads:[~2016-03-29 14:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <56FA62FB.1080506@broadcom.com>
2016-03-29 14:02 ` Al Viro [this message]
2016-03-29 19:17   ` [REGRESSION 4.6-rc1] NFS mounts (using autofs) failing Arend van Spriel
2016-03-29 22:36     ` Junichi Nomura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160329140244.GV17997@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=arend.vanspriel@broadcom.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).