From: Mike Frysinger <vapier@gentoo.org>
To: Felix Janda <felix.janda@posteo.de>
Cc: libtirpc-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org
Subject: Re: [Libtirpc-devel] [PATCH 1/7] des_impl: Use bzero instead of __bzero
Date: Sun, 17 Apr 2016 12:17:08 -0400 [thread overview]
Message-ID: <20160417161708.GF5369@vapier.lan> (raw)
In-Reply-To: <20160417091004.GA2737@nyan>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On 17 Apr 2016 11:10, Felix Janda wrote:
> Fixes compilation error with musl libc:
>
> .libs/libtirpc_la-des_impl.o: In function `_des_crypt':
> src/des_impl.c:591: undefined reference to `__bzero'
>
> --- a/src/des_impl.c
> +++ b/src/des_impl.c
> @@ -588,7 +588,7 @@ _des_crypt (char *buf, unsigned len, struct desparams *desp)
> }
> tin0 = tin1 = tout0 = tout1 = xor0 = xor1 = 0;
> tbuf[0] = tbuf[1] = 0;
> - __bzero (schedule, sizeof (schedule));
> + bzero (schedule, sizeof (schedule));
might as well convert to memset while you're at it since bzero is deprecated
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-17 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-17 9:10 [PATCH 1/7] des_impl: Use bzero instead of __bzero Felix Janda
2016-04-17 16:17 ` Mike Frysinger [this message]
2016-04-17 17:45 ` [PATCH v2] Replace bzero and __bzero by memset Felix Janda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160417161708.GF5369@vapier.lan \
--to=vapier@gentoo.org \
--cc=felix.janda@posteo.de \
--cc=libtirpc-devel@lists.sourceforge.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).