From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: romieu@fr.zoreil.com, festevam@gmail.com, edumazet@google.com,
chuck.lever@oracle.com, trond.myklebust@primarydata.com,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: fix lockdep splat in tcp_snd_una_update()
Date: Wed, 04 May 2016 00:54:43 -0400 (EDT) [thread overview]
Message-ID: <20160504.005443.219521798076710212.davem@davemloft.net> (raw)
In-Reply-To: <1462319763.5535.329.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 03 May 2016 16:56:03 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> tcp_snd_una_update() and tcp_rcv_nxt_update() call
> u64_stats_update_begin() either from process context or BH handler.
>
> This triggers a lockdep splat on 32bit & SMP builds.
>
> We could add u64_stats_update_begin_bh() variant but this would
> slow down 32bit builds with useless local_disable_bh() and
> local_enable_bh() pairs, since we own the socket lock at this point.
>
> I add sock_owned_by_me() helper to have proper lockdep support
> even on 64bit builds, and new u64_stats_update_begin_raw()
> and u64_stats_update_end_raw methods.
>
> Fixes: c10d9310edf5 ("tcp: do not assume TCP code is non preemptible")
> Reported-by: Fabio Estevam <festevam@gmail.com>
> Diagnosed-by: Francois Romieu <romieu@fr.zoreil.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2016-05-04 4:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 23:18 Cannot use NFS with linux-next 20160429 Fabio Estevam
2016-05-01 19:52 ` Chuck Lever
2016-05-03 19:37 ` Fabio Estevam
2016-05-03 22:31 ` Francois Romieu
2016-05-03 22:35 ` Eric Dumazet
2016-05-03 23:56 ` [PATCH net-next] tcp: fix lockdep splat in tcp_snd_una_update() Eric Dumazet
2016-05-04 1:26 ` Fabio Estevam
2016-05-04 4:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504.005443.219521798076710212.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chuck.lever@oracle.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=festevam@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).