From: Chuck Lever <chuck.lever@oracle.com>
To: bfields@fieldses.org
Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v2 4/9] svcrdma: Remove superfluous line from rdma_read_chunks()
Date: Wed, 04 May 2016 10:53:14 -0400 [thread overview]
Message-ID: <20160504145314.6602.32998.stgit@klimt.1015granger.net> (raw)
In-Reply-To: <20160504144730.6602.89073.stgit@klimt.1015granger.net>
Clean up: svc_rdma_get_read_chunk() already returns a pointer
to the Read list. No need to set "ch" again to the value it
already contains.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
index 234be9d..12e7899 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
@@ -447,10 +447,8 @@ static int rdma_read_chunks(struct svcxprt_rdma *xprt,
head->arg.len = rqstp->rq_arg.len;
head->arg.buflen = rqstp->rq_arg.buflen;
- ch = (struct rpcrdma_read_chunk *)&rmsgp->rm_body.rm_chunks[0];
- position = be32_to_cpu(ch->rc_position);
-
/* RDMA_NOMSG: RDMA READ data should land just after RDMA RECV data */
+ position = be32_to_cpu(ch->rc_position);
if (position == 0) {
head->arg.pages = &head->pages[0];
page_offset = head->byte_len;
next prev parent reply other threads:[~2016-05-04 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 14:52 [PATCH v2 0/9] NFS/RDMA server patches proposed for v4.7 Chuck Lever
2016-05-04 14:52 ` [PATCH v2 1/9] svcrdma: Support IPv6 with NFS/RDMA Chuck Lever
2016-05-04 14:52 ` [PATCH v2 2/9] svcrdma: Do not add XDR padding to xdr_buf page vector Chuck Lever
2016-05-04 14:53 ` [PATCH v2 3/9] svcrdma: svc_rdma_put_context() is invoked twice in Send error path Chuck Lever
2016-05-04 14:53 ` Chuck Lever [this message]
2016-05-04 14:53 ` [PATCH v2 5/9] svcrdma: Post Receives only for forward channel requests Chuck Lever
2016-05-04 14:53 ` [PATCH v2 6/9] svcrdma: Drain QP before freeing svcrdma_xprt Chuck Lever
2016-05-04 14:53 ` [PATCH v2 7/9] svcrdma: Eliminate code duplication in svc_rdma_recvfrom() Chuck Lever
2016-05-04 14:53 ` [PATCH v2 8/9] svcrdma: Generalize svc_rdma_xdr_decode_req() Chuck Lever
2016-05-04 14:53 ` [PATCH v2 9/9] svcrdma: Simplify the check for backward direction replies Chuck Lever
2016-05-13 20:12 ` [PATCH v2 0/9] NFS/RDMA server patches proposed for v4.7 J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504145314.6602.32998.stgit@klimt.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).