linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: NeilBrown <nfbrown@novell.com>
Cc: Richard Weinberger <richard@nod.at>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	NFS List <linux-nfs@vger.kernel.org>
Subject: Re: Reconsidering exportable UBIFS
Date: Mon, 9 May 2016 00:25:33 +0100	[thread overview]
Message-ID: <20160508232533.GH2694@ZenIV.linux.org.uk> (raw)
In-Reply-To: <871t5curbl.fsf@notabene.neil.brown.name>

On Mon, May 09, 2016 at 08:18:22AM +1000, NeilBrown wrote:

> Not puppies, just kittens.
> 
> If you don't provide these functions, then exporting with
> "subtree_check" won't work.  That is no great loss except that people
> might find the failure confusing.

	OK, a client sends you a RENAME.  With fhandles of both parents +
old and new names in those.  Your task, should you choose to accept it, is
to figure out whether we should fail with nfserr_inval due to an attempt
to make a directory its own descendent.  Without being able to locate all
ancestors of a directory.

	You are fond of complaining about the checks that could've been left
to server not getting skipped on the client.  Now you want to skip them on
the server side as well?  Can't have it both ways...

	Seriously, it really doesn't work.  You can't do directory
modifications without having found the chain of ancestors.  No ->get_parent()
is OK _only_ for something like tmpfs, where we have the full chains of
ancestors towards root all the time.  For UBIFS it's obviously not true.
Not unless you suck the entire directory tree in memory at the mount time.

  reply	other threads:[~2016-05-08 23:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5702E7F5.1050807@nod.at>
2016-05-08 22:18 ` Reconsidering exportable UBIFS NeilBrown
2016-05-08 23:25   ` Al Viro [this message]
2016-05-09  5:03     ` NeilBrown
2016-05-11 14:09       ` Richard Weinberger
2016-05-11 14:10   ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160508232533.GH2694@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=dedekind1@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=nfbrown@novell.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).