* [patch] NFS: checking for NULL instead of IS_ERR() in nfs_commit_file()
@ 2016-05-23 10:21 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-05-23 10:21 UTC (permalink / raw)
To: Trond Myklebust, Anna Schumaker; +Cc: linux-nfs, kernel-janitors
nfs_create_request() doesn't return NULL, it returns error pointers.
Fixes: 67911c8f18b5 ('NFS: Add nfs_commit_file()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 4dac51b..54a4eb6 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -1735,8 +1735,8 @@ int nfs_commit_file(struct file *file, struct nfs_write_verifier *verf)
open = get_nfs_open_context(nfs_file_open_context(file));
req = nfs_create_request(open, NULL, NULL, 0, i_size_read(inode));
- if (!req) {
- ret = -ENOMEM;
+ if (IS_ERR(req)) {
+ ret = PTR_ERR(req);
goto out_put;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-05-23 10:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-23 10:21 [patch] NFS: checking for NULL instead of IS_ERR() in nfs_commit_file() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).