From: "George Spelvin" <linux@sciencehorizons.net>
To: geert@linux-m68k.org, linux@sciencehorizons.net
Cc: alistair.francis@xilinx.com, bfields@fieldses.org,
gerg@linux-m68k.org, jlayton@poochiereds.net,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org,
linux-nfs@vger.kernel.org, michal.simek@xilinx.com,
tglx@linutronix.de, torvalds@linux-foundation.org,
uclinux-h8-devel@lists.sourceforge.jp,
ysato@users.sourceforge.jp
Subject: Re: [PATCH 00/10] String hash improvements
Date: 25 May 2016 04:11:28 -0400 [thread overview]
Message-ID: <20160525081128.6920.qmail@ns.sciencehorizons.net> (raw)
In-Reply-To: <CAMuHMdUUCYfGfX1CDVxxihGSC+dz2D1JJVXUWC5H0_W-MmHe7Q@mail.gmail.com>
Geert Uytterhoeven wrote:
> Usually this is handled through include/asm-generic/.
> Put the generic default implementation in include/asm-generic/hash.h.
>
> Architectures that need to override provide their own version, e.g.
> arch/m68k/include/asm/hash.h. They may #include <asm-generic/hash.h>
> if they still want to reuse parts of the generic implementation.
>
> Other architectures add "generic-y += hash.h" to their
> arch/<ARCH>/include/asm/Kbuild.
I thought about that, but then I'd have to edit *every* architecture,
and might need acks from all the maintainers.
I was looking for something that was a total no-op on most architectures.
But if this is preferred, it's not technically difficult at all.
If asm-generic were in the <asm/*.h> search path, it would magically
Just Work, but leftover files from a broken checkout would be a big
potential problem.
next prev parent reply other threads:[~2016-05-25 8:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+55aFxPSW+84KfQ1N_WmND-wtvgj2zQm8nFPkRcc+gyU=uing@mail.gmail.com>
2016-05-25 7:20 ` [PATCH 00/10] String hash improvements George Spelvin
2016-05-25 8:00 ` Geert Uytterhoeven
2016-05-25 8:11 ` George Spelvin [this message]
2016-05-25 8:50 ` Geert Uytterhoeven
2016-05-25 9:07 ` George Spelvin
2016-05-25 16:08 ` Linus Torvalds
[not found] ` <1464465443-25305-1-git-send-email-linux@sciencehorizons.net>
2016-05-28 19:57 ` [PATCH v3 03/10] <linux/sunrpc/svcauth.h>: Define hash_str() in terms of hashlen_string() George Spelvin
2016-06-02 22:59 ` [PATCH 00/10] String hash improvements Fubo Chen
2016-05-25 7:26 ` [PATCH 03/10] <linux/sunrpc/svcauth.h>: Define hash_str() in terms of hash_string() George Spelvin
2016-05-26 18:39 ` [PATCH RESEND " George Spelvin
2016-05-26 18:45 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525081128.6920.qmail@ns.sciencehorizons.net \
--to=linux@sciencehorizons.net \
--cc=alistair.francis@xilinx.com \
--cc=bfields@fieldses.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=jlayton@poochiereds.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).