From: "George Spelvin" <linux@sciencehorizons.net>
To: geert@linux-m68k.org, linux@sciencehorizons.net
Cc: alistair.francis@xilinx.com, bfields@fieldses.org,
gerg@linux-m68k.org, jlayton@poochiereds.net,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org,
linux-nfs@vger.kernel.org, michal.simek@xilinx.com,
tglx@linutronix.de, torvalds@linux-foundation.org,
uclinux-h8-devel@lists.sourceforge.jp,
ysato@users.sourceforge.jp
Subject: Re: [PATCH 00/10] String hash improvements
Date: 25 May 2016 05:07:45 -0400 [thread overview]
Message-ID: <20160525090745.8999.qmail@ns.sciencehorizons.net> (raw)
In-Reply-To: <CAMuHMdUuAi_EdWPJmYNgNpUv_Zh34Oc3G7TgqcsChwzuyz0c-Q@mail.gmail.com>
>> +#if defined(CONFIG_M68000) || defined(CONFIG_M68010)
> As I said before, I don't think you need this check, given HAVE_ARCH_HASH is
> selected by M68000, and M68010 doesn't exist.
I was going belt & suspenders on general principles, but yes, I'm happy
to leave it out.
I noticed that CONFIG_M68010 doesn't exist in Linus' tree, but you
recommended it, so I thought you might know something I don't.
> As you only include <asm/archhash.h> if CONFIG_HAVE_ARCH_HASH
> is defined, you can also just call the arch-specific one <asm/hash.h>.
Yes, that's a possibility, too. But weren't we still discussing whether
I should use conditional #inclusion based on a symbol, or asm-generic?
If neither of us has a killer argument that convinces the other, style
issues like this are amenable to voting, so I was going to wait a little
bit for others to chime in.
Thank you very much for the comments!
next prev parent reply other threads:[~2016-05-25 9:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+55aFxPSW+84KfQ1N_WmND-wtvgj2zQm8nFPkRcc+gyU=uing@mail.gmail.com>
2016-05-25 7:20 ` [PATCH 00/10] String hash improvements George Spelvin
2016-05-25 8:00 ` Geert Uytterhoeven
2016-05-25 8:11 ` George Spelvin
2016-05-25 8:50 ` Geert Uytterhoeven
2016-05-25 9:07 ` George Spelvin [this message]
2016-05-25 16:08 ` Linus Torvalds
[not found] ` <1464465443-25305-1-git-send-email-linux@sciencehorizons.net>
2016-05-28 19:57 ` [PATCH v3 03/10] <linux/sunrpc/svcauth.h>: Define hash_str() in terms of hashlen_string() George Spelvin
2016-06-02 22:59 ` [PATCH 00/10] String hash improvements Fubo Chen
2016-05-25 7:26 ` [PATCH 03/10] <linux/sunrpc/svcauth.h>: Define hash_str() in terms of hash_string() George Spelvin
2016-05-26 18:39 ` [PATCH RESEND " George Spelvin
2016-05-26 18:45 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525090745.8999.qmail@ns.sciencehorizons.net \
--to=linux@sciencehorizons.net \
--cc=alistair.francis@xilinx.com \
--cc=bfields@fieldses.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=jlayton@poochiereds.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).