* [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix
@ 2016-06-05 9:23 Geert Uytterhoeven
2016-06-05 10:21 ` Jeff Layton
0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2016-06-05 9:23 UTC (permalink / raw)
To: J. Bruce Fields, Jeff Layton; +Cc: linux-nfs, linux-kernel, Geert Uytterhoeven
On 32-bit:
fs/nfsd/blocklayout.c: In function ‘nfsd4_block_get_device_info_scsi’:
fs/nfsd/blocklayout.c:337: warning: integer constant is too large for ‘long’ type
fs/nfsd/blocklayout.c:344: warning: integer constant is too large for ‘long’ type
fs/nfsd/blocklayout.c: In function ‘nfsd4_scsi_fence_client’:
fs/nfsd/blocklayout.c:385: warning: integer constant is too large for ‘long’ type
Add the missing "ULL" postfix to 64-bit constant NFSD_MDS_PR_KEY to fix
this.
Fixes: f99d4fbdae6765d0 ("nfsd: add SCSI layout support")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
v2:
- Add Reviewed-by.
Despite Bruce's "Thanks, applying for 4.6.--b." on 2016-03-29, this
still hasn't made it into next-20160603.
---
fs/nfsd/blocklayout.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c
index e55b5242614da7a9..31f3df193bdbb47b 100644
--- a/fs/nfsd/blocklayout.c
+++ b/fs/nfsd/blocklayout.c
@@ -290,7 +290,7 @@ out_free_buf:
return error;
}
-#define NFSD_MDS_PR_KEY 0x0100000000000000
+#define NFSD_MDS_PR_KEY 0x0100000000000000ULL
/*
* We use the client ID as a unique key for the reservations.
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix
2016-06-05 9:23 [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix Geert Uytterhoeven
@ 2016-06-05 10:21 ` Jeff Layton
2016-06-06 18:56 ` J. Bruce Fields
0 siblings, 1 reply; 7+ messages in thread
From: Jeff Layton @ 2016-06-05 10:21 UTC (permalink / raw)
To: Geert Uytterhoeven, J. Bruce Fields; +Cc: linux-nfs, linux-kernel
On Sun, 2016-06-05 at 11:23 +0200, Geert Uytterhoeven wrote:
> On 32-bit:
>
> fs/nfsd/blocklayout.c: In function ‘nfsd4_block_get_device_info_scsi’:
> fs/nfsd/blocklayout.c:337: warning: integer constant is too large for ‘long’ type
> fs/nfsd/blocklayout.c:344: warning: integer constant is too large for ‘long’ type
> fs/nfsd/blocklayout.c: In function ‘nfsd4_scsi_fence_client’:
> fs/nfsd/blocklayout.c:385: warning: integer constant is too large for ‘long’ type
>
> Add the missing "ULL" postfix to 64-bit constant NFSD_MDS_PR_KEY to fix
> this.
>
> Fixes: f99d4fbdae6765d0 ("nfsd: add SCSI layout support")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> v2:
> - Add Reviewed-by.
>
> Despite Bruce's "Thanks, applying for 4.6.--b." on 2016-03-29, this
> still hasn't made it into next-20160603.
> ---
> fs/nfsd/blocklayout.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c
> index e55b5242614da7a9..31f3df193bdbb47b 100644
> --- a/fs/nfsd/blocklayout.c
> +++ b/fs/nfsd/blocklayout.c
> @@ -290,7 +290,7 @@ out_free_buf:
> return error;
> }
>
> -#define NFSD_MDS_PR_KEY 0x0100000000000000
> +#define NFSD_MDS_PR_KEY 0x0100000000000000ULL
>
> /*
> * We use the client ID as a unique key for the reservations.
Thanks!
Reviewed-by: Jeff Layton <jlayton@poochiereds.net>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix
2016-06-05 10:21 ` Jeff Layton
@ 2016-06-06 18:56 ` J. Bruce Fields
0 siblings, 0 replies; 7+ messages in thread
From: J. Bruce Fields @ 2016-06-06 18:56 UTC (permalink / raw)
To: Jeff Layton; +Cc: Geert Uytterhoeven, linux-nfs, linux-kernel
On Sun, Jun 05, 2016 at 06:21:43AM -0400, Jeff Layton wrote:
> On Sun, 2016-06-05 at 11:23 +0200, Geert Uytterhoeven wrote:
> > On 32-bit:
> >
> > fs/nfsd/blocklayout.c: In function ‘nfsd4_block_get_device_info_scsi’:
> > fs/nfsd/blocklayout.c:337: warning: integer constant is too large for ‘long’ type
> > fs/nfsd/blocklayout.c:344: warning: integer constant is too large for ‘long’ type
> > fs/nfsd/blocklayout.c: In function ‘nfsd4_scsi_fence_client’:
> > fs/nfsd/blocklayout.c:385: warning: integer constant is too large for ‘long’ type
> >
> > Add the missing "ULL" postfix to 64-bit constant NFSD_MDS_PR_KEY to fix
> > this.
> >
> > Fixes: f99d4fbdae6765d0 ("nfsd: add SCSI layout support")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > ---
> > v2:
> > - Add Reviewed-by.
> >
> > Despite Bruce's "Thanks, applying for 4.6.--b." on 2016-03-29, this
> > still hasn't made it into next-20160603.
Apologies, I did apply that to my local 4.6 branch, but I never
collected any more 4.6 patches, and forgot to send a pull request. I
think I've bugfixes for the current kernel slip by before this way, so I
need a better system.... Thanks for the reminder, feel free to bug me
again if this hasn't gone upstream by next week.
--b.
> > ---
> > fs/nfsd/blocklayout.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c
> > index e55b5242614da7a9..31f3df193bdbb47b 100644
> > --- a/fs/nfsd/blocklayout.c
> > +++ b/fs/nfsd/blocklayout.c
> > @@ -290,7 +290,7 @@ out_free_buf:
> > return error;
> > }
> >
> > -#define NFSD_MDS_PR_KEY 0x0100000000000000
> > +#define NFSD_MDS_PR_KEY 0x0100000000000000ULL
> >
> > /*
> > * We use the client ID as a unique key for the reservations.
>
> Thanks!
>
> Reviewed-by: Jeff Layton <jlayton@poochiereds.net>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix
@ 2016-03-25 10:47 Geert Uytterhoeven
2016-03-25 18:04 ` Christoph Hellwig
0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2016-03-25 10:47 UTC (permalink / raw)
To: Christoph Hellwig, J. Bruce Fields, Jeff Layton
Cc: linux-nfs, linux-kernel, Geert Uytterhoeven
On 32-bit:
fs/nfsd/blocklayout.c: In function ‘nfsd4_block_get_device_info_scsi’:
fs/nfsd/blocklayout.c:337: warning: integer constant is too large for ‘long’ type
fs/nfsd/blocklayout.c:344: warning: integer constant is too large for ‘long’ type
fs/nfsd/blocklayout.c: In function ‘nfsd4_scsi_fence_client’:
fs/nfsd/blocklayout.c:385: warning: integer constant is too large for ‘long’ type
Add the missing "ULL" postfix to 64-bit constant NFSD_MDS_PR_KEY to fix
this.
Fixes: f99d4fbdae6765d0 ("nfsd: add SCSI layout support")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
fs/nfsd/blocklayout.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c
index e55b5242614da7a9..31f3df193bdbb47b 100644
--- a/fs/nfsd/blocklayout.c
+++ b/fs/nfsd/blocklayout.c
@@ -290,7 +290,7 @@ out_free_buf:
return error;
}
-#define NFSD_MDS_PR_KEY 0x0100000000000000
+#define NFSD_MDS_PR_KEY 0x0100000000000000ULL
/*
* We use the client ID as a unique key for the reservations.
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix
2016-03-25 10:47 Geert Uytterhoeven
@ 2016-03-25 18:04 ` Christoph Hellwig
2016-03-25 18:25 ` Joe Perches
2016-03-28 23:48 ` J. Bruce Fields
0 siblings, 2 replies; 7+ messages in thread
From: Christoph Hellwig @ 2016-03-25 18:04 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Christoph Hellwig, J. Bruce Fields, Jeff Layton, linux-nfs,
linux-kernel
Looks fine, thanks!
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix
2016-03-25 18:04 ` Christoph Hellwig
@ 2016-03-25 18:25 ` Joe Perches
2016-03-28 23:48 ` J. Bruce Fields
1 sibling, 0 replies; 7+ messages in thread
From: Joe Perches @ 2016-03-25 18:25 UTC (permalink / raw)
To: Christoph Hellwig, Geert Uytterhoeven
Cc: J. Bruce Fields, Jeff Layton, linux-nfs, linux-kernel
On Fri, 2016-03-25 at 19:04 +0100, Christoph Hellwig wrote:
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Outside of the known 64 bit only uses,
this shows a few oddities too:
$ git grep -P -w -i '0x[0-9a-f]{9,16}(?!ull|ll)'
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix
2016-03-25 18:04 ` Christoph Hellwig
2016-03-25 18:25 ` Joe Perches
@ 2016-03-28 23:48 ` J. Bruce Fields
1 sibling, 0 replies; 7+ messages in thread
From: J. Bruce Fields @ 2016-03-28 23:48 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Geert Uytterhoeven, Jeff Layton, linux-nfs, linux-kernel
On Fri, Mar 25, 2016 at 07:04:22PM +0100, Christoph Hellwig wrote:
> Looks fine, thanks!
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks, applying for 4.6.--b.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-06-06 18:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-05 9:23 [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix Geert Uytterhoeven
2016-06-05 10:21 ` Jeff Layton
2016-06-06 18:56 ` J. Bruce Fields
-- strict thread matches above, loose matches on Subject: below --
2016-03-25 10:47 Geert Uytterhoeven
2016-03-25 18:04 ` Christoph Hellwig
2016-03-25 18:25 ` Joe Perches
2016-03-28 23:48 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).