From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tom Haynes <thomas.haynes@primarydata.com>
Cc: Trond Myklebust <trondmy@primarydata.com>,
Anna Schumaker <Anna.Schumaker@netapp.com>,
linux-nfs@vger.kernel.org
Subject: Re: [RFC 0/2] Sharing flex file XDR encoding between client and server
Date: Mon, 13 Jun 2016 15:45:43 -0400 [thread overview]
Message-ID: <20160613194543.GC19825@fieldses.org> (raw)
In-Reply-To: <1465342486-21750-1-git-send-email-loghyr@primarydata.com>
On Tue, Jun 07, 2016 at 04:34:44PM -0700, Tom Haynes wrote:
> This builds on my prior change set for the flex file server.
>
> I'm not too hot on putting this much code in a header, but
> I can't think of a cleaner way without leaking too much
> between the client and server.
>
> Any guidance on how this is typically approached?
Looks like there's some cut-and-paste from net/sunrpc/addr.c. Any
reason not to just use those functions and/or add any necessary new
stuff there?
--b.
>
> Thanks,
> Tom
>
>
> Tom Haynes (2):
> nfs: Encoding a netaddr is common to client and server
> nfsd: Encode a netaddr correctly
>
> fs/nfs/flexfilelayout/flexfilelayout.c | 93 +-----------------------------
> fs/nfs/flexfilelayout/flexfilelayout.h | 5 +-
> fs/nfsd/flexfilelayout.c | 26 +--------
> fs/nfsd/flexfilelayoutxdr.c | 34 +++++------
> fs/nfsd/flexfilelayoutxdr.h | 15 +----
> include/linux/nfs4_ff.h | 100 +++++++++++++++++++++++++++++++++
> 6 files changed, 120 insertions(+), 153 deletions(-)
> create mode 100644 include/linux/nfs4_ff.h
>
> --
> 2.5.5
prev parent reply other threads:[~2016-06-13 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 23:34 [RFC 0/2] Sharing flex file XDR encoding between client and server Tom Haynes
2016-06-07 23:34 ` [RFC 1/2] nfs: Encoding a netaddr is common to " Tom Haynes
2016-06-07 23:34 ` [RFC 2/2] nfsd: Encode a netaddr correctly Tom Haynes
2016-06-13 19:45 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613194543.GC19825@fieldses.org \
--to=bfields@fieldses.org \
--cc=Anna.Schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=thomas.haynes@primarydata.com \
--cc=trondmy@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).