linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Scott Mayhew <smayhew@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH RESEND] sunrpc: add gss minor status to svcauth_gss_proxy_init
Date: Wed, 15 Jun 2016 16:27:16 -0400	[thread overview]
Message-ID: <20160615202716.GD3848@fieldses.org> (raw)
In-Reply-To: <1465998031-53086-1-git-send-email-smayhew@redhat.com>

On Wed, Jun 15, 2016 at 09:40:31AM -0400, Scott Mayhew wrote:
> GSS-Proxy doesn't produce very much debug logging at all.  Printing out
> the gss minor status will aid in troubleshooting if the
> GSS_Accept_sec_context upcall fails.

Thanks.  It'd be nice to have some better debugging tools for gss-proxy
communication, though.  Either logging in gssd, or maybe a tool that
traced gss-proxy IO and helped interpret it?

Anyway, no harm to this, I guess, applying.

--b.

> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
>  net/sunrpc/auth_gss/svcauth_gss.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
> index e085f5a..1d28181 100644
> --- a/net/sunrpc/auth_gss/svcauth_gss.c
> +++ b/net/sunrpc/auth_gss/svcauth_gss.c
> @@ -1230,8 +1230,9 @@ static int svcauth_gss_proxy_init(struct svc_rqst *rqstp,
>  	if (status)
>  		goto out;
>  
> -	dprintk("RPC:       svcauth_gss: gss major status = %d\n",
> -			ud.major_status);
> +	dprintk("RPC:       svcauth_gss: gss major status = %d "
> +			"minor status = %d\n",
> +			ud.major_status, ud.minor_status);
>  
>  	switch (ud.major_status) {
>  	case GSS_S_CONTINUE_NEEDED:
> -- 
> 2.4.11

      reply	other threads:[~2016-06-15 20:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15 13:40 [PATCH RESEND] sunrpc: add gss minor status to svcauth_gss_proxy_init Scott Mayhew
2016-06-15 20:27 ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160615202716.GD3848@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=smayhew@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).