[PATCH RESEND] sunrpc: add gss minor status to svcauth_gss_proxy_init

[PATCH RESEND] sunrpc: add gss minor status to svcauth_gss_proxy_init

[Scott Mayhew]

GSS-Proxy doesn't produce very much debug logging at all.  Printing out
the gss minor status will aid in troubleshooting if the
GSS_Accept_sec_context upcall fails.

Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
 net/sunrpc/auth_gss/svcauth_gss.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
index e085f5a..1d28181 100644
--- a/net/sunrpc/auth_gss/svcauth_gss.c
+++ b/net/sunrpc/auth_gss/svcauth_gss.c
@@ -1230,8 +1230,9 @@ static int svcauth_gss_proxy_init(struct svc_rqst *rqstp,
 	if (status)
 		goto out;
 
-	dprintk("RPC:       svcauth_gss: gss major status = %d\n",
-			ud.major_status);
+	dprintk("RPC:       svcauth_gss: gss major status = %d "
+			"minor status = %d\n",
+			ud.major_status, ud.minor_status);
 
 	switch (ud.major_status) {
 	case GSS_S_CONTINUE_NEEDED:
-- 
2.4.11

Re: [PATCH RESEND] sunrpc: add gss minor status to svcauth_gss_proxy_init

[J. Bruce Fields]

On Wed, Jun 15, 2016 at 09:40:31AM -0400, Scott Mayhew wrote:
> GSS-Proxy doesn't produce very much debug logging at all.  Printing out
> the gss minor status will aid in troubleshooting if the
> GSS_Accept_sec_context upcall fails.

Thanks.  It'd be nice to have some better debugging tools for gss-proxy
communication, though.  Either logging in gssd, or maybe a tool that
traced gss-proxy IO and helped interpret it?

Anyway, no harm to this, I guess, applying.

--b.

> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
>  net/sunrpc/auth_gss/svcauth_gss.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
> index e085f5a..1d28181 100644
> --- a/net/sunrpc/auth_gss/svcauth_gss.c
> +++ b/net/sunrpc/auth_gss/svcauth_gss.c
> @@ -1230,8 +1230,9 @@ static int svcauth_gss_proxy_init(struct svc_rqst *rqstp,
>  	if (status)
>  		goto out;
>  
> -	dprintk("RPC:       svcauth_gss: gss major status = %d\n",
> -			ud.major_status);
> +	dprintk("RPC:       svcauth_gss: gss major status = %d "
> +			"minor status = %d\n",
> +			ud.major_status, ud.minor_status);
>  
>  	switch (ud.major_status) {
>  	case GSS_S_CONTINUE_NEEDED:
> -- 
> 2.4.11