From: Christoph Hellwig <hch@lst.de>
To: Artem Savkov <asavkov@redhat.com>
Cc: Anna Schumaker <Anna.Schumaker@netapp.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
trond.myklebust@primarydata.com, hch@lst.de
Subject: Re: [PATCH v2] Fix NULL pointer dereference in bl_free_device().
Date: Thu, 21 Jul 2016 10:09:10 +0200 [thread overview]
Message-ID: <20160721080910.GA20363@lst.de> (raw)
In-Reply-To: <1468942744-10646-1-git-send-email-asavkov@redhat.com>
On Tue, Jul 19, 2016 at 05:39:04PM +0200, Artem Savkov wrote:
> When bl_parse_deviceid() fails in bl_alloc_deviceid_node() on
> blkdev_get_by_*() step we get an pnfs_block_dev struct that is
> uninitialized except for bdev field which is set to whatever error
> blkdev_get_by_*() returns. bl_free_device() then tries to call
> blkdev_put() if bdev is not 0 resulting in a wrong pointer dereference.
>
> Fixing this by making sure bdev is not an error code in bl_free_device().
>
> Signed-off-by: Artem Savkov <asavkov@redhat.com>
I guess this is fine to be defensive, but we should probably just ensure
->bdev is NULLed on failure.
next prev parent reply other threads:[~2016-07-21 8:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 11:30 [PATCH] Fix NULL pointer dereference in bl_free_device() Artem Savkov
2016-07-19 13:57 ` Anna Schumaker
2016-07-19 15:21 ` Anna Schumaker
2016-07-19 15:39 ` [PATCH v2] " Artem Savkov
2016-07-21 8:09 ` Christoph Hellwig [this message]
2016-07-21 11:32 ` [PATCH v3] " Artem Savkov
2016-07-21 12:30 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721080910.GA20363@lst.de \
--to=hch@lst.de \
--cc=Anna.Schumaker@netapp.com \
--cc=asavkov@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).