From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Anna Schumaker <Anna.Schumaker@netapp.com>,
Christoph Hellwig <hch@infradead.org>,
linux-nfs@vger.kernel.org, Trond.Myklebust@primarydata.com
Subject: Re: [PATCH v4 0/3] NFSv4.2: Add support for the COPY operation
Date: Mon, 1 Aug 2016 06:30:46 -0700 [thread overview]
Message-ID: <20160801133046.GB26191@infradead.org> (raw)
In-Reply-To: <20160729185933.GA7964@fieldses.org>
On Fri, Jul 29, 2016 at 02:59:33PM -0400, J. Bruce Fields wrote:
> > > I don't see any obvious problem with the nfsd code, other than the
> > > obvious issue with large synchronous copies tying up server threads and
> > > leaving clients waiting--but maybe we should just see how people end up
> > > using it and deal with the problems as they come up.
>
> I'm still worrying about this, though.
>
> As a simple stopgap, could we just set *some* maximum on the size of the
> copy? Or better yet on the time?--that'd let filesystems with
> clone-like features copy the whole file without blocking an nfsd thread
> indefinitely in the case of other filesystems.
I'm still really worried about corner cases in the copy_file_range
syscall and the COPY nfs implementation. When Darrick implemented
xfstests support for clone we found various bugs in the existing
implementation and corner cases handled different by xfs/btrfs/nfs and
the documentation. I'd really like to see something similar for
the copy side. Especially as clone should always be a valid
implementation for copy as well.
prev parent reply other threads:[~2016-08-01 13:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 20:42 [PATCH v4 0/3] NFSv4.2: Add support for the COPY operation Anna Schumaker
2016-04-29 20:42 ` [PATCH v4 1/3] NFS: Add nfs_commit_file() Anna Schumaker
2016-04-29 20:42 ` [PATCH v4 2/3] NFS: Add COPY nfs operation Anna Schumaker
2016-04-29 20:42 ` [PATCH v4 3/3] NFSD: Implement the COPY call Anna Schumaker
2016-04-29 20:42 ` [RFC v4 4/3] vfs_copy_range() test program Anna Schumaker
2016-05-01 17:37 ` [PATCH v4 0/3] NFSv4.2: Add support for the COPY operation Christoph Hellwig
2016-05-13 20:31 ` J. Bruce Fields
2016-05-13 20:58 ` Anna Schumaker
2016-07-29 18:59 ` J. Bruce Fields
2016-07-29 19:40 ` Anna Schumaker
2016-07-29 20:20 ` J. Bruce Fields
2016-07-29 20:44 ` Anna Schumaker
2016-07-29 21:21 ` J. Bruce Fields
2016-08-02 18:48 ` J. Bruce Fields
2016-08-26 20:32 ` Anna Schumaker
2016-08-01 13:30 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801133046.GB26191@infradead.org \
--to=hch@infradead.org \
--cc=Anna.Schumaker@netapp.com \
--cc=Trond.Myklebust@primarydata.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).