Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-nfs@vger.kernel.org,
	Trond Myklebust <trondmy@primarydata.com>
Subject: Re: [PATCH] nfsd: don't set a FL_LAYOUT lease for flexfiles layouts
Date: Thu, 11 Aug 2016 14:14:00 -0400	[thread overview]
Message-ID: <20160811181400.GA2114@fieldses.org> (raw)
In-Reply-To: <1470937318.30238.44.camel@redhat.com>

On Thu, Aug 11, 2016 at 01:41:58PM -0400, Jeff Layton wrote:
> On Thu, 2016-08-11 at 19:38 +0200, Christoph Hellwig wrote:
> > This looks fine to me, although it might be a good idea to just
> > have a flags field in the layout_ops structure for additional
> > quirks in the future instead of the boolean.
> 
> 
> Sure...that's reasonable. If and when the need arises for more flags we
> can always do the conversion to a flags field then as well.
> 
> I'll Bruce make the call on which he'd rather see...

I don't really care, so... I'll take your version as is barring other
objections.

--b.

      reply	other threads:[~2016-08-11 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 17:36 [PATCH] nfsd: don't set a FL_LAYOUT lease for flexfiles layouts Jeff Layton
2016-08-11 17:38 ` Christoph Hellwig
2016-08-11 17:41   ` Jeff Layton
2016-08-11 18:14     ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160811181400.GA2114@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=hch@lst.de \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox